Skip to content

Commit 01bf789

Browse files
Copilotjtemporal
andcommitted
Address PR feedback: revert infrastructure changes and update card structure
- Undo puppeteer-config.json (removed file) - Undo changes to config_manager.py (reverted to original) - Update pretitle/title/subtitle: "Switching" / "branches" / "when creating a new branch" - Update descriptors to use \n for line breaks in longer descriptions - SVG needs regeneration in CI/CD environment with proper Chrome/sandbox support Co-authored-by: jtemporal <6595551+jtemporal@users.noreply.github.com>
1 parent 9d61a4a commit 01bf789

File tree

3 files changed

+7
-19
lines changed

3 files changed

+7
-19
lines changed

en/_posts/2021-08-25-014.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
---
22
layout: post
3-
pretitle: Switching branches when
4-
title: creating
5-
subtitle: a new branch
3+
pretitle: Switching
4+
title: branches
5+
subtitle: when creating a new branch
66
command: git checkout -b name
77
descriptors:
8-
- command: command to switch branches
9-
- part1: flag to create the branch
10-
- part2: name of the new branch
8+
- command: command to\nswitch branches
9+
- part1: flag to create\nthe branch
10+
- part2: name of the\nnew branch
1111
author: "@jtemporal"
1212
number: "014"
1313
mermaid: true

puppeteer-config.json

Lines changed: 0 additions & 3 deletions
This file was deleted.

scripts/config_manager.py

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ def _setup_paths(self):
4040
# Theme configuration
4141
self.theme_path = self.root_dir / 'gitfichas-mermaid-theme.json'
4242

43-
# Puppeteer configuration
44-
self.puppeteer_config_path = self.root_dir / 'puppeteer-config.json'
45-
4643
def _setup_directories(self):
4744
"""Create required directories if they don't exist."""
4845
self.images_dir.mkdir(parents=True, exist_ok=True)
@@ -95,7 +92,7 @@ def cleanup_temp_files(self):
9592

9693
def get_mermaid_cli_command(self, temp_file: Path, output_path: Path) -> list:
9794
"""Get the Mermaid CLI command arguments."""
98-
cmd = [
95+
return [
9996
'npx', '@mermaid-js/mermaid-cli',
10097
'-i', str(temp_file),
10198
'-o', str(output_path),
@@ -107,12 +104,6 @@ def get_mermaid_cli_command(self, temp_file: Path, output_path: Path) -> list:
107104
'--cssFile', str(self.combined_css_path)
108105
]
109106

110-
# Add puppeteer config if it exists
111-
if self.puppeteer_config_path.exists():
112-
cmd.extend(['--puppeteerConfigFile', str(self.puppeteer_config_path)])
113-
114-
return cmd
115-
116107
def get_image_path(self, front_matter: Dict[str, Any], file_path: Path) -> Path:
117108
"""Determine the output image path based on front matter and file path."""
118109
number = front_matter.get('number', file_path.stem.split('-')[-1])

0 commit comments

Comments
 (0)