Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jtablesaw/tablesaw
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1adef315c77e335c997417a9e913f195d62ad3d7
Choose a base ref
...
head repository: jtablesaw/tablesaw
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4d47a22bed278a8b6ea9d8b5fc2077bd85269cc3
Choose a head ref
  • 6 commits
  • 27 files changed
  • 4 contributors

Commits on Apr 27, 2021

  1. Configuration menu
    Copy the full SHA
    875c18c View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. fix bug in appendCell that caused custom parser to be ignored (#912)

    In TextColumn, calling appendCell(string, parser) failed because the results of the call to parser.parse(string) was passed to appendObj(), which called parse again, this time using the default parser. This is fixed.
    
    This commit also makes it possible to directly set the missingValueStrings list in a custom parser.
    lwhite1 authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    20a1775 View commit details
    Browse the repository at this point in the history
  2. Printformatting (#914)

    * first commit
    
    This branch is for evaluating the possibility of using ColumnPrintFormatters to optionally format output.
    
    There will be a writeOption called ```usePrintFormatters(boolean)``` that turns the logic on or off. It will be off by default, matching the current status.
    
    The print formatter is set on the column and would then be used by both table.print and table.write, providing more consistent output
    
    PrintFormatters have the advantage of handling missing values so the user does not have to worry about them blowing up a Java NumberFormatter for instance, while allowing the user to set the missing value symbol for each column.
    
    * Added some tests for print formatting for IntColumn and DateColumn
    
    * Creating a class hierarchy for the existing Column Formatters. Additional tests, renamed methods
    
    * fix a few issues. added a test for formatting booleans
    
    * More tests
    
    * addressing some sonar warnings
    
    * Fixed latent NPE in InstantColumn
    
    added test for InstantColumn formatting
    removed TODO
    
    * Simplified method in CsvWriter
    
    removed one unused line
    
    * Update CsvWriter.java
    
    * add a test to show it can avoid scientific notation
    
    * implement suggestions from code review
    lwhite1 authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    f0ab9ab View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    56508ba View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. Configuration menu
    Copy the full SHA
    61ca25a View commit details
    Browse the repository at this point in the history
  2. Fix minor PR suggestions

    Change System.lineSeparator() for a constant to be less verbose
    Change mockUrl to be able to use URLs
    lujop committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    4d47a22 View commit details
    Browse the repository at this point in the history
Loading