From 81d0e8bea4dc3dac17ea47bf797a257ee266698b Mon Sep 17 00:00:00 2001 From: Kanitkorn S Date: Sun, 19 Aug 2018 09:38:12 +0700 Subject: [PATCH] Remove test cases for `always` option in state-in-constructor rule Since `always` is the default option, we can use the no-option cases to cover these `always` cases. I left one `always` case to make sure that having an option as `always` will act the same way as no-option. --- tests/lib/rules/state-in-constructor.js | 119 ------------------------ 1 file changed, 119 deletions(-) diff --git a/tests/lib/rules/state-in-constructor.js b/tests/lib/rules/state-in-constructor.js index ec8057fae2..a09233ad1c 100644 --- a/tests/lib/rules/state-in-constructor.js +++ b/tests/lib/rules/state-in-constructor.js @@ -36,15 +36,6 @@ ruleTester.run('state-in-constructor', rule, { } } ` - }, { - code: ` - class Foo extends React.Component { - render() { - return
Foo
- } - } - `, - options: ['always'] }, { code: ` class Foo extends React.Component { @@ -92,20 +83,6 @@ ruleTester.run('state-in-constructor', rule, { } } ` - }, { - code: ` - class Foo extends React.Component { - constructor(props) { - super(props) - this.state = { bar: 0 } - } - baz = { bar: 0 } - render() { - return
Foo
- } - } - `, - options: ['always'] }, { code: ` class Foo extends React.Component { @@ -118,19 +95,6 @@ ruleTester.run('state-in-constructor', rule, { } } ` - }, { - code: ` - class Foo extends React.Component { - constructor(props) { - super(props) - this.baz = { bar: 0 } - } - render() { - return
Foo
- } - } - `, - options: ['always'] }, { code: ` class Foo extends React.Component { @@ -153,16 +117,6 @@ ruleTester.run('state-in-constructor', rule, { } } ` - }, { - code: ` - class Foo extends React.Component { - baz = { bar: 0 } - render() { - return
Foo
- } - } - `, - options: ['always'] }, { code: ` class Foo extends React.Component { @@ -177,11 +131,6 @@ ruleTester.run('state-in-constructor', rule, { code: ` const Foo = () =>
Foo
` - }, { - code: ` - const Foo = () =>
Foo
- `, - options: ['always'] }, { code: ` const Foo = () =>
Foo
@@ -193,13 +142,6 @@ ruleTester.run('state-in-constructor', rule, { return
Foo
} ` - }, { - code: ` - function Foo () { - return
Foo
- } - `, - options: ['always'] }, { code: ` function Foo () { @@ -289,19 +231,6 @@ ruleTester.run('state-in-constructor', rule, { errors: [{ message: 'State initialization should be in a constructor' }] - }, { - code: ` - class Foo extends React.Component { - state = { bar: 0 } - render() { - return
Foo
- } - } - `, - options: ['always'], - errors: [{ - message: 'State initialization should be in a constructor' - }] }, { code: ` class Foo extends React.Component { @@ -315,20 +244,6 @@ ruleTester.run('state-in-constructor', rule, { errors: [{ message: 'State initialization should be in a constructor' }] - }, { - code: ` - class Foo extends React.Component { - state = { bar: 0 } - baz = { bar: 0 } - render() { - return
Foo
- } - } - `, - options: ['always'], - errors: [{ - message: 'State initialization should be in a constructor' - }] }, { code: ` class Foo extends React.Component { @@ -345,39 +260,6 @@ ruleTester.run('state-in-constructor', rule, { errors: [{ message: 'State initialization should be in a constructor' }] - }, { - code: ` - class Foo extends React.Component { - constructor(props) { - super(props) - this.baz = { bar: 0 } - } - state = { baz: 0 } - render() { - return
Foo
- } - } - `, - options: ['always'], - errors: [{ - message: 'State initialization should be in a constructor' - }] - }, { - code: ` - class Foo extends React.Component { - constructor(props) { - super(props) - this.state = { bar: 0 } - } - state = { baz: 0 } - render() { - return
Foo
- } - } - `, - errors: [{ - message: 'State initialization should be in a constructor' - }] }, { code: ` class Foo extends React.Component { @@ -391,7 +273,6 @@ ruleTester.run('state-in-constructor', rule, { } } `, - options: ['always'], errors: [{ message: 'State initialization should be in a constructor' }]