[eslint] enable and manually fix no-useless-escape

Author: ljharb

.eslintrc

@@ -26,7 +26,6 @@
 
         "prefer-destructuring": [2, { "array": false, "object": false }, { "enforceForRenamedProperties": false }],
 
-        "no-useless-escape": 1,
         "function-paren-newline": 0,
         "no-plusplus": 1,
         "no-param-reassign": 1,

lib/rules/forbid-elements.js

@@ -104,7 +104,7 @@ module.exports = {
 
         if (argType === 'Identifier' && /^[A-Z_]/.test(argument.name)) {
           reportIfForbidden(argument.name, argument);
-        } else if (argType === 'Literal' && /^[a-z][^\.]*$/.test(argument.value)) {
+        } else if (argType === 'Literal' && /^[a-z][^.]*$/.test(argument.value)) {
           reportIfForbidden(argument.value, argument);
         } else if (argType === 'MemberExpression') {
           reportIfForbidden(sourceCode.getText(argument), argument);

lib/util/error.js

@@ -5,7 +5,7 @@
  * @param {String} message - Message to log.
  */
 function error(message) {
-  if (!/\=-(f|-format)=/.test(process.argv.join('='))) {
+  if (!/=-(f|-format)=/.test(process.argv.join('='))) {
     // eslint-disable-next-line no-console
     console.error(message);
   }

lib/util/jsx.js

@@ -6,7 +6,7 @@
 
 const elementType = require('jsx-ast-utils/elementType');
 
-const COMPAT_TAG_REGEX = /^[a-z]|\-/;
+const COMPAT_TAG_REGEX = /^[a-z]|-/;
 
 /**
  * Checks if a node represents a DOM element.

lib/util/log.js

@@ -5,7 +5,7 @@
  * @param {String} message - Message to log.
  */
 function log(message) {
-  if (!/\=-(f|-format)=/.test(process.argv.join('='))) {
+  if (!/=-(f|-format)=/.test(process.argv.join('='))) {
     // eslint-disable-next-line no-console
     console.log(message);
   }

lib/util/propTypes.js

@@ -30,7 +30,7 @@ function isSuperTypeParameterPropsDeclaration(node) {
  * @param {string} string the identifier to strip
  */
 function stripQuotes(string) {
-  return string.replace(/^\'|\'$/g, '');
+  return string.replace(/^'|'$/g, '');
 }
 
 /**

lib/util/usedPropTypes.js

@@ -181,7 +181,7 @@ module.exports = function usedPropTypesInstructions(context, components, utils)
    * @param {string} string the identifier to strip
    */
   function stripQuotes(string) {
-    return string.replace(/^\'|\'$/g, '');
+    return string.replace(/^'|'$/g, '');
   }
 
   /**

tests/lib/rules/no-unescaped-entities.js

@@ -199,7 +199,7 @@ ruleTester.run('no-unescaped-entities', rule, {
         });
       `,
       parser: parsers.BABEL_ESLINT,
-      errors: [{message: 'HTML entity, \`&\` , must be escaped.'}],
+      errors: [{message: 'HTML entity, `&` , must be escaped.'}],
       options: [{
         forbid: ['&']
       }]
@@ -211,7 +211,7 @@ ruleTester.run('no-unescaped-entities', rule, {
           }
         });
       `,
-      errors: [{message: 'HTML entity, \`&\` , must be escaped.'}],
+      errors: [{message: 'HTML entity, `&` , must be escaped.'}],
       options: [{
         forbid: ['&']
       }]

tests/lib/rules/no-unused-prop-types.js

@@ -2642,10 +2642,10 @@ ruleTester.run('no-unused-prop-types', rule, {
     }, {
       code: `
         type Props = {
-          \'completed?\': boolean,
+          'completed?': boolean,
         };
         const Hello = (props: Props): React.Element => {
-          return <div>{props[\'completed?\']}</div>;
+          return <div>{props['completed?']}</div>;
         }
       `,
       parser: parsers.BABEL_ESLINT

tests/lib/rules/no-unused-state.js

@@ -344,7 +344,7 @@ eslintTester.run('no-unused-state', rule, {
           this.state = { foo: 0, bar: 1 };
         }
         render() {
-          const bar = \'bar\';
+          const bar = 'bar';
           return <SomeComponent bar={this.state[bar]} />;
         }
       }`,
@@ -1016,7 +1016,7 @@ eslintTester.run('no-unused-state', rule, {
             const foo = ((this: any).state: any).foo;
             const {bar, ...others} = (this.state: any);
             let baz;
-            baz = (others: any)[\'baz\'];
+            baz = (others: any)['baz'];
             return <SomeComponent foo={foo} bar={bar} baz={baz} />;
           }
         }`,