chore: upgrade eslint-plugin-eslint-plugin to v4

https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/releases/tag/v4.0.0

Author: bmish

.eslintrc

@@ -42,6 +42,9 @@
           "requireParamDescription": false,
           "requireReturnDescription": false,
         }],
+
+        "eslint-plugin/consistent-output": 0,
+        "eslint-plugin/require-meta-type": 0
     },
     "overrides": [
       {

lib/rules/forbid-prop-types.js

@@ -142,7 +142,10 @@ module.exports = {
         }
         case 'CallExpression': {
           const innerNode = node.arguments && node.arguments[0];
-          if (propWrapperUtil.isPropWrapperFunction(context, context.getSource(node.callee)) && innerNode) {
+          if (
+            propWrapperUtil.isPropWrapperFunction(context, context.getSourceCode().getText(node.callee))
+            && innerNode
+          ) {
             checkNode(innerNode);
           }
           break;

lib/rules/jsx-closing-tag-location.js

@@ -27,8 +27,8 @@ module.exports = {
       url: docsUrl('jsx-closing-tag-location')
     },
     fixable: 'whitespace',
-
-    messages
+    messages,
+    schema: []
   },
 
   create(context) {

lib/rules/jsx-curly-spacing.js

@@ -371,13 +371,13 @@ module.exports = {
       }
 
       const sourceCode = context.getSourceCode();
-      const first = context.getFirstToken(node);
+      const first = context.getSourceCode().getFirstToken(node);
       const last = sourceCode.getLastToken(node);
-      let second = context.getTokenAfter(first, {includeComments: true});
+      let second = context.getSourceCode().getTokenAfter(first, {includeComments: true});
       let penultimate = sourceCode.getTokenBefore(last, {includeComments: true});
 
       if (!second) {
-        second = context.getTokenAfter(first);
+        second = context.getSourceCode().getTokenAfter(first);
         const leadingComments = sourceCode.getNodeByRangeIndex(second.range[0]).leadingComments;
         second = leadingComments ? leadingComments[0] : second;
       }

lib/rules/jsx-no-constructed-context-values.js

@@ -136,7 +136,8 @@ module.exports = {
       recommended: false,
       url: docsUrl('jsx-no-constructed-context-values')
     },
-    messages
+    messages,
+    schema: []
   },
 
   create(context) {

lib/rules/jsx-no-useless-fragment.js

@@ -93,7 +93,18 @@ module.exports = {
       recommended: false,
       url: docsUrl('jsx-no-useless-fragment')
     },
-    messages
+    messages,
+    schema: [
+      {
+        type: 'object',
+        properties: {
+          allowExpressions: {
+            type: 'boolean'
+          }
+        },
+        additionalProperties: false
+      }
+    ]
   },
 
   create(context) {

lib/rules/jsx-sort-default-props.js

@@ -61,7 +61,7 @@ module.exports = {
       // (babel-eslint@5 does not expose property name so we have to rely on tokens)
       }
       if (node.type === 'ClassProperty') {
-        const tokens = context.getFirstTokens(node, 2);
+        const tokens = context.getSourceCode().getFirstTokens(node, 2);
         return tokens[1] && tokens[1].type === 'Identifier' ? tokens[1].value : tokens[0].value;
       }
       return '';

package.json

@@ -52,7 +52,7 @@
     "babel-eslint": "^8 || ^9 || ^10.1.0",
     "eslint": "^3 || ^4 || ^5 || ^6 || ^7",
     "eslint-config-airbnb-base": "^14.2.1",
-    "eslint-plugin-eslint-plugin": "^2.3.0 || ^3.5.3",
+    "eslint-plugin-eslint-plugin": "^2.3.0 || ^3.5.3 || ^4.0.1",
     "eslint-plugin-import": "^2.24.2",
     "eslint-remote-tester": "^1.3.1",
     "eslint-remote-tester-repositories": "^0.0.3",