From ef9a24c008e80b6bde09fbb54a47cdcd25e1cc39 Mon Sep 17 00:00:00 2001 From: Haddas Bronfman <85441461+haddasbronfman@users.noreply.github.com> Date: Fri, 3 Mar 2023 18:59:56 +0200 Subject: [PATCH] Expand pool.name in semantic conventions (#3050) according to the discussion here: https://github.com/open-telemetry/opentelemetry-specification/issues/3038 I'm updating the `pool.name attribute` --- specification/metrics/semantic_conventions/database-metrics.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/metrics/semantic_conventions/database-metrics.md b/specification/metrics/semantic_conventions/database-metrics.md index 6b34a54..82b4a56 100644 --- a/specification/metrics/semantic_conventions/database-metrics.md +++ b/specification/metrics/semantic_conventions/database-metrics.md @@ -58,4 +58,4 @@ Below is a table of the attributes that MUST be included on all connection pool | Name | Type | Description | Examples | Requirement Level | |-------------|--------|------------------------------------------------------------------------------|----------------|-------------------| -| `pool.name` | string | The name of the connection pool; unique within the instrumented application. | `myDataSource` | Required | +| `pool.name` | string | The name of the connection pool; unique within the instrumented application. In case the connection pool implementation does not provide a name, then the [db.connection_string](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/database.md#connection-level-attributes) should be used. | `myDataSource` | Required |