Skip to content

Commit b6f369b

Browse files
committed
fix for issues silkimen#220 and silkimen#286
When responseType is set to json, the data should be returned as plain json string, not as a base64 encoded string.
1 parent 39fa17e commit b6f369b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/android/com/silkimen/cordovahttp/CordovaHttpBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ protected void processResponse(HttpRequest request, CordovaHttpResponse response
193193
response.setHeaders(request.headers());
194194

195195
if (request.code() >= 200 && request.code() < 300) {
196-
if ("text".equals(this.responseType)) {
196+
if ("text".equals(this.responseType) || "json".equals(this.responseType)) {
197197
String decoded = HttpBodyDecoder.decodeBody(outputStream.toByteArray(), request.charset());
198198
response.setBody(decoded);
199199
} else {

src/ios/CordovaHttpPlugin.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ - (void)setTimeout:(NSTimeInterval)timeout forManager:(AFHTTPSessionManager*)man
6262
}
6363

6464
- (void)setResponseSerializer:(NSString*)responseType forManager:(AFHTTPSessionManager*)manager {
65-
if ([responseType isEqualToString: @"text"]) {
65+
if ([responseType isEqualToString: @"text"] || [responseType isEqualToString: @"json"]) {
6666
manager.responseSerializer = [TextResponseSerializer serializer];
6767
} else {
6868
manager.responseSerializer = [BinaryResponseSerializer serializer];

0 commit comments

Comments
 (0)