Skip to content

Commit 5b9d000

Browse files
author
Juan
authored
DevTools: Include Edge in browser name detection (facebook#22584)
1 parent 2af4a79 commit 5b9d000

File tree

1 file changed

+16
-3
lines changed
  • packages/react-devtools-extensions/src

1 file changed

+16
-3
lines changed

packages/react-devtools-extensions/src/utils.js

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,25 @@
22

33
import type {BrowserTheme} from 'react-devtools-shared/src/devtools/views/DevTools';
44

5-
const IS_CHROME = navigator.userAgent.indexOf('Firefox') < 0;
5+
const IS_EDGE = navigator.userAgent.indexOf('Edg') >= 0;
6+
const IS_FIREFOX = navigator.userAgent.indexOf('Firefox') >= 0;
7+
const IS_CHROME = IS_EDGE === false && IS_FIREFOX === false;
68

7-
export type BrowserName = 'Chrome' | 'Firefox';
9+
export type BrowserName = 'Chrome' | 'Firefox' | 'Edge';
810

911
export function getBrowserName(): BrowserName {
10-
return IS_CHROME ? 'Chrome' : 'Firefox';
12+
if (IS_EDGE) {
13+
return 'Edge';
14+
}
15+
if (IS_FIREFOX) {
16+
return 'Firefox';
17+
}
18+
if (IS_CHROME) {
19+
return 'Chrome';
20+
}
21+
throw new Error(
22+
'Expected browser name to be one of Chrome, Edge or Firefox.',
23+
);
1124
}
1225

1326
export function getBrowserTheme(): BrowserTheme {

0 commit comments

Comments
 (0)