Are dependencies only resolved if a file is specified in jsrepo.config.ts?

[mmailaender]

I've specified multiple times folders instead of files

{
  name: 'lib/auth',
  add: 'when-added',
  type: 'lib',
  files: [
    {
      path: 'src/lib/auth'
    }
  ]
},
{
  "name": "primitives",
  "add": "when-needed",
  "type": "lib",
  "files": [
    {
      "path": "src/lib/primitives"
    }
  ]
}

and it seems the dependencies referenced in the files of the folders are not getting installed
e.g.

@lucide/svelte/icons/mail (imported by /home/user/github/test/src/lib/auth/ui/SignIn.svelte?id=0)
@lucide/svelte/icons/circle-check (imported by /home/user/github/test/src/lib/primitives/ui/sonner/sonner.svelte?id=0)
clsx (imported by /home/user/github/test/src/lib/primitives/utils.ts)
@lucide/svelte/icons/circle-x (imported by /home/user/github/test/src/lib/primitives/ui/sonner/sonner.svelte?id=0)
tailwind-merge (imported by /home/user/github/test/src/lib/primitives/utils.ts)
tailwind-variants (imported by /home/user/github/test/src/lib/primitives/ui/toggle/toggle.svelte?id=0)
@lucide/svelte/icons/info (imported by /home/user/github/test/src/lib/primitives/ui/sonner/sonner.svelte?id=0)
@lucide/svelte/icons/chevron-right (imported by /home/user/github/test/src/lib/primitives/ui/menu/menu-trigger-item.svelte?id=0)
@lucide/svelte/icons/eye (imported by /home/user/github/test/src/lib/primitives/ui/password/password-toggle-visibility.svelte?id=0)
@lucide/svelte/icons/eye-off (imported by /home/user/github/test/src/lib/primitives/ui/password/password-toggle-visibility.svelte?id=0)

Are dependencies only resolved if a file is specified in jsrepo.config.ts? I was expecting it to be resolved for folders as well.

[ieedan]

No they should be installed. Do they come up in your build output?

[mmailaender]

Not seeing a relevant difference in the registry.json. It was adding the entry as usual to the devDependency block (Except it was not adding the "version": "^2.1.1", but I tried adding it manually to the registry.json and it seems not making a difference):

The following item is manually dependency managed (svelte-sonner):

{
  "type": "base",
  "role": "file",
  "path": "src/routes/layout.css",
  "relativePath": "src/routes/layout.css",
  "_imports_": [],
  "registryDependencies": [],
  "dependencies": [],
  "devDependencies": [
    {
      "ecosystem": "js",
      "name": "@skeletonlabs/skeleton"
    },
    {
      "ecosystem": "js",
      "name": "tw-animate-css"
    },
    {
      "ecosystem": "js",
      "name": "@types/node"
    },
    {
      "ecosystem": "js",
      "name": "svelte-sonner"
    }
  ]
}

and this one is automatic dependency managed:

{
  "name": "routes/reset-password",
  "type": "routes",
  "add": "when-added",
  "registryDependencies": ["primitives", "lib/auth"],
  "dependencies": [],
  "devDependencies": [
    {
      "ecosystem": "js",
      "name": "svelte-sonner",
      "version": "^1.0.6"
    },
    {
      "ecosystem": "js",
      "name": "@lucide/svelte",
      "version": "^0.555.0"
    }
  ],
  "files": [
    {
      "type": "routes",
      "role": "file",
      "path": "reset-password/+page.svelte",
      "relativePath": "src/routes/reset-password/+page.svelte",
      "_imports_": [
        {
          "import": "$lib/primitives/ui/password",
          "item": "primitives",
          "file": {
            "type": "lib",
            "path": "primitives/ui/password/index.ts"
          },
          "meta": {}
        },
        {
          "import": "$lib/auth/api/auth-client",
          "item": "lib/auth",
          "file": {
            "type": "lib",
            "path": "auth/api/auth-client.ts"
          },
          "meta": {}
        }
      ],
      "registryDependencies": [],
      "dependencies": [],
      "devDependencies": []
    }
  ]
}

[ieedan]

Can you try and create a small reproduction?

[mmailaender]

Hmm, a bit tricky to isolate since the files reference each other quite heavily 🤔
But the branch you checked yesterday is fully up to date and already shows the behavior clearly.

Branch: https://github.com/mmailaender/Convex-Better-Auth-UI/tree/feat/jsrepo-v3

Using svelte-sonner as the example:

Manual dev-dependency resolution (adding it here does install the dev dependency):
https://github.com/mmailaender/Convex-Better-Auth-UI/blob/feat/jsrepo-v3/svelte/jsrepo.config.ts#L261

Automatic dependency resolution entry in registry.json:
https://github.com/mmailaender/Convex-Better-Auth-UI/blob/feat/jsrepo-v3/svelte/registry.json#L527

Manual dependency resolution entry in registry.json:
https://github.com/mmailaender/Convex-Better-Auth-UI/blob/feat/jsrepo-v3/svelte/registry.json#L4784

If this still isn’t enough to debug the issue, happy to try whatever setup you think would make a better minimal reproduction — just let me know what direction you'd prefer.

[ieedan]

I found it. Fix coming...

[ieedan]

#717