Skip to content

Commit a704bd0

Browse files
authored
fix: Fix an issue where dev dependencies weren't installed (#717)
1 parent 7f9f8ff commit a704bd0

File tree

2 files changed

+39
-14
lines changed

2 files changed

+39
-14
lines changed

.changeset/whole-fans-brush.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"jsrepo": patch
3+
---
4+
5+
fix: Fix an issue where dev dependencies weren't installed
6+

packages/jsrepo/src/utils/add.ts

Lines changed: 33 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -140,12 +140,16 @@ export type ResolvedWantedItem = {
140140
registry: ResolvedRegistry;
141141
item: {
142142
name: string;
143-
description?: string;
144-
add?: RegistryItemAdd;
143+
description: string | undefined;
144+
add: RegistryItemAdd | undefined;
145145
type: RegistryItemType;
146-
registryDependencies?: string[];
147-
dependencies?: (RemoteDependency | string)[];
146+
registryDependencies: string[] | undefined;
147+
dependencies: (RemoteDependency | string)[] | undefined;
148+
devDependencies: (RemoteDependency | string)[] | undefined;
148149
files: Array<RepositoryOutputFile | DistributedOutputManifestFile>;
150+
envVars: Record<string, string> | undefined;
151+
categories: string[] | undefined;
152+
meta: Record<string, string> | undefined;
149153
};
150154
};
151155

@@ -239,26 +243,31 @@ export async function resolveWantedItems(
239243

240244
export type ResolvedItem = {
241245
name: string;
242-
description?: string;
243-
add?: RegistryItemAdd;
246+
description: string | undefined;
247+
add: RegistryItemAdd | undefined;
244248
type: RegistryItemType;
245-
dependencies?: (RemoteDependency | string)[];
249+
registryDependencies: string[] | undefined;
250+
dependencies: (RemoteDependency | string)[] | undefined;
251+
devDependencies: (RemoteDependency | string)[] | undefined;
246252
registry: ResolvedRegistry;
247253
files: Array<RepositoryOutputFile | DistributedOutputManifestFile>;
254+
envVars: Record<string, string> | undefined;
255+
categories: string[] | undefined;
256+
meta: Record<string, string> | undefined;
248257
};
249258

250259
export type ItemRepository = {
251260
name: string;
252261
type: RegistryItemType;
253-
add?: RegistryItemAdd;
254-
description?: string;
255-
dependencies?: (RemoteDependency | string)[];
256-
devDependencies?: (RemoteDependency | string)[];
262+
add: RegistryItemAdd | undefined;
263+
description: string | undefined;
264+
dependencies: (RemoteDependency | string)[] | undefined;
265+
devDependencies: (RemoteDependency | string)[] | undefined;
257266
registry: ResolvedRegistry;
258267
files: Array<RepositoryOutputFile & { content: string }>;
259-
envVars?: Record<string, string>;
260-
categories?: string[];
261-
meta?: Record<string, string>;
268+
envVars: Record<string, string> | undefined;
269+
categories: string[] | undefined;
270+
meta: Record<string, string> | undefined;
262271
};
263272

264273
export type ItemDistributed = DistributedOutputItem & { registry: ResolvedRegistry };
@@ -335,8 +344,12 @@ async function fetchItemRepositoryMode(
335344
add: item.add,
336345
description: item.description,
337346
dependencies: item.dependencies,
347+
devDependencies: item.devDependencies,
338348
registry: item.registry,
339349
files: filesResult,
350+
envVars: item.envVars,
351+
categories: item.categories,
352+
meta: item.meta,
340353
});
341354
}
342355

@@ -643,10 +656,16 @@ export function resolveTree(
643656
resolvedItems.set(wantedItem.item.name, {
644657
name: wantedItem.item.name,
645658
type: wantedItem.item.type,
659+
description: wantedItem.item.description,
646660
add: wantedItem.item.add,
661+
registryDependencies: wantedItem.item.registryDependencies,
647662
dependencies: wantedItem.item.dependencies,
663+
devDependencies: wantedItem.item.devDependencies,
648664
registry: wantedItem.registry,
649665
files: wantedItem.item.files,
666+
envVars: wantedItem.item.envVars,
667+
categories: wantedItem.item.categories,
668+
meta: wantedItem.item.meta,
650669
});
651670

652671
const resolvedRegistryDependencies = resolveTree(needsResolving, {

0 commit comments

Comments
 (0)