Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persistence to ad banner #710

Merged
merged 10 commits into from
Oct 17, 2024
Merged

Add persistence to ad banner #710

merged 10 commits into from
Oct 17, 2024

Conversation

byron-okta
Copy link
Contributor

@byron-okta byron-okta commented Oct 14, 2024

Description

This PR does the following:

  • Add persistence of the state for the ad banner through local storage, so when users close the ad banner for the current campaign value defined by the messageBar.id.value property, it won't show the ad banner when users revisit the page.
  • Updates the copy for the ad banner to promote the best of devday.
  • Moves the GitHub action to test the app due to agreement.
  • We also fixed a layout shift caused by the image on the hero banner.

How to test it

  • Navigate to the home page and verify that it loads the ad banner. Then, click on the close icon and refresh the page. Verify that it doesn't show the ad banner again.

@florkaa florkaa merged commit a806960 into master Oct 17, 2024
2 checks passed
@florkaa florkaa deleted the add-persistence-to-ad-banner branch October 17, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants