refactor: Cleanup test from @param annotations #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DannyvdSluijs
force-pushed
the
Replace-param-annotation-with-native-type-hint-in-tests
branch
from
e360671 to
1702f6d
Compare
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (6)
- tests/Constraints/FactoryTest.php: Language not supported
- tests/Constraints/TypeTest.php: Language not supported
- tests/Constraints/VeryBaseTestCase.php: Language not supported
- tests/Drafts/BaseDraftTestCase.php: Language not supported
- tests/Entity/JsonPointerTest.php: Language not supported
- tests/Rfc3339Test.php: Language not supported
DannyvdSluijs
deleted the
Replace-param-annotation-with-native-type-hint-in-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the test files in the
testsdirectory, focusing on enforcing strict types, improving method signatures, and using generators for data providers. The most important changes include adding strict types, refactoring method signatures, and converting data providers to use generators for better performance and readability.Enforcing Strict Types:
declare(strict_types=1);at the beginning of multiple test files to enforce strict type checking. (tests/Constraints/FactoryTest.php[1]tests/Constraints/VeryBaseTestCase.php[2]tests/Drafts/BaseDraftTestCase.php[3]tests/Entity/JsonPointerTest.php[4]tests/Rfc3339Test.php[5]Refactoring Method Signatures:
tests/Constraints/FactoryTest.php[1]tests/Constraints/TypeTest.php[2]tests/Constraints/VeryBaseTestCase.php[3]tests/Drafts/BaseDraftTestCase.php[4]tests/Entity/JsonPointerTest.php[5]tests/Rfc3339Test.php[6]Using Generators for Data Providers:
tests/Constraints/FactoryTest.php[1]tests/Entity/JsonPointerTest.php[2]tests/Rfc3339Test.php[3]