Merge pull request ServiceStack#159 from fpischedda/master

added missing BitCount method to RedisClient

Author: mythz

src/ServiceStack.Redis/Commands.cs

@@ -78,6 +78,7 @@ public static class Commands
         public readonly static byte[] SetRange = "SETRANGE".ToUtf8Bytes();
         public readonly static byte[] GetBit = "GETBIT".ToUtf8Bytes();
         public readonly static byte[] SetBit = "SETBIT".ToUtf8Bytes();
+        public readonly static byte[] BitCount = "BITCOUNT".ToUtf8Bytes();
 
         public readonly static byte[] RPush = "RPUSH".ToUtf8Bytes();
         public readonly static byte[] LPush = "LPUSH".ToUtf8Bytes();

src/ServiceStack.Redis/Generic/RedisTypedTransaction.cs

@@ -101,7 +101,7 @@ public bool Commit()
                     queuedCommand.ProcessResult();
                 }
             }
-            catch (RedisTransactionFailedException e)
+            catch (RedisTransactionFailedException)
             {
                 rc = false;
             }

src/ServiceStack.Redis/RedisNativeClient.cs

@@ -546,6 +546,14 @@ public long SetBit(string key, int offset, int value)
             return SendExpectLong(Commands.SetBit, key.ToUtf8Bytes(), offset.ToUtf8Bytes(), value.ToUtf8Bytes());
         }
 
+        public long BitCount(string key)
+        {
+            if (key == null)
+                throw new ArgumentNullException("key");
+
+            return SendExpectLong(Commands.BitCount, key.ToUtf8Bytes());
+        }
+
         public string RandomKey()
         {
             return SendExpectData(Commands.RandomKey).FromUtf8Bytes();

src/ServiceStack.Redis/Transaction/RedisTransaction.cs

@@ -100,7 +100,7 @@ public bool Commit()
                     queuedCommand.ProcessResult();
                 }
             }
-            catch (RedisTransactionFailedException e)
+            catch (RedisTransactionFailedException)
             {
                 rc = false;
             }

tests/ServiceStack.Redis.Tests/Generic/RedisClientTests.cs

@@ -116,12 +116,13 @@ public void Can_StoreAll_RedisTypedClient()
 		}
 
         [Test]
-        public void Can_SetBit_And_GetBit()
+        public void Can_SetBit_And_GetBit_And_BitCount()
         {
             const string key = "BitKey";
             const int offset = 100;
             Redis.SetBit(key, offset, 1);
             Assert.AreEqual(1, Redis.GetBit(key,offset));
+            Assert.AreEqual(1, Redis.BitCount(key));
         }
 
 		[Test, Explicit]