Skip to content

Commit 9e39aac

Browse files
Add warning about test timezones (#401)
Co-authored-by: Andrew Coleman <andrew_coleman@uk.ibm.com>
1 parent 87b9b92 commit 9e39aac

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

CONTRIBUTING.md

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ At a minimum, please include:
2121
- Version of `jsonata` - either release number if you downloaded a zip, or the first few lines of `git log` if you are cloning the repository directly.
2222
- Version of Node.js (`node -v`), or browser vendor and version.
2323

24+
2425
## Feature requests
2526

2627
tba
@@ -41,6 +42,14 @@ Signed-off-by: John Doe <john.doe@hisdomain.com>
4142

4243
### Coding standards
4344

44-
Please ensure you follow the coding standards used through-out the existing code base. Coding standards are checked by ESLint. 100% test coverage must be maintained at all times. Run the following command to check coding rules and test coverage:
45+
Please ensure you follow the coding standards used through-out the existing code base. Coding standards are checked by ESLint. 100% test coverage must be maintained at all times.
46+
47+
## Running tests
48+
49+
Tests are written using Mocha and can be run directly via NPM.
50+
51+
```
52+
npm test
53+
```
4554

46-
- npm t
55+
> *Timezones* There are a number of tests that test date functionality. In order for these tests to pass they need to be run in GMT time. (Since Jan 1 in GMT is still Dec 31 in any timezone further west). The workaround is to update your system clock to be in GMT while you are running tests.

0 commit comments

Comments
 (0)