Skip to content

Update css bootstrap links in examples #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2015

Conversation

Minisai
Copy link
Contributor

@Minisai Minisai commented Mar 25, 2015

No description provided.

@Minisai Minisai changed the title Fix stylesheet's links in html examples Fix stylesheet's links in examples Mar 25, 2015
@Dervisevic
Copy link
Contributor

That's good, i would prefer it if you kept the // instead of https:// as getting the files can take up to 5x as long, and that's not necessary when surfing without SSL. If you disagree, please do tell.

@Minisai Minisai force-pushed the development branch 3 times, most recently from f3cd2dd to 83f9ed5 Compare March 25, 2015 20:36
@Minisai Minisai changed the title Fix stylesheet's links in examples Update css bootstrap links in examples Mar 25, 2015
@Minisai
Copy link
Contributor Author

Minisai commented Mar 25, 2015

@Dervisevic Thank you for the remark! I've updated the PR. Protocol-related urls is good solution, but if you open file locally, browser would prefix it with "file://" protocol. As I understand these examples were created mostly for use on github pages, but at the same time I haven't found custom-validators page there?

@stramel
Copy link
Contributor

stramel commented Mar 25, 2015

@Minisai It looks like the custom-validators page was just created within the past week. I'm sure @davidlgj or @Dervisevic will get it up on the website soon. They currently just have a link to the example in the ngModelController section

I agree for protocol-less URLs 👍

Dervisevic added a commit that referenced this pull request Mar 27, 2015
Update css bootstrap links in examples
@Dervisevic Dervisevic merged commit adf550c into json-schema-form:development Mar 27, 2015
@davidlgj
Copy link
Contributor

davidlgj commented Apr 1, 2015

@Minisai we should probably add some server to the gulpfile to make it easier to test out the examples. I usually use http-server or puer. The examples also play a second role to ease manual testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants