Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactorings for JSON:API extensions to unblock OpenAPI support #1629

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Nov 11, 2024

Exposes internal-only extensibility points for validating and writing JSON:API extension data during serialization. This is needed for OpenAPI support, which requires our own JSON:API extension to handle resource inheritance.

Renamed JsonApiExtension to JsonApiMediaTypeExtension, to reserve the name for future use.

QUALITY CHECKLIST

@bkoelman bkoelman changed the title Refactorings for JSON:API extensions to unblock OpenAPI integration Refactorings for JSON:API extensions to unblock OpenAPI support Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 90.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.73%. Comparing base (43c1a4b) to head (3840fcb).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...lization/JsonConverters/ResourceObjectConverter.cs 92.50% 1 Missing and 2 partials ⚠️
.../JsonApiDotNetCore/Middleware/JsonApiMiddleware.cs 33.33% 0 Missing and 2 partials ⚠️
...c/JsonApiDotNetCore/Middleware/JsonApiMediaType.cs 88.88% 1 Missing ⚠️
...DotNetCore/Middleware/JsonApiMediaTypeExtension.cs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1629      +/-   ##
==========================================
+ Coverage   90.72%   90.73%   +0.01%     
==========================================
  Files         352      353       +1     
  Lines       11447    11492      +45     
  Branches     1881     1888       +7     
==========================================
+ Hits        10385    10427      +42     
- Misses        695      696       +1     
- Partials      367      369       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review November 11, 2024 22:41
@bkoelman bkoelman merged commit 8323836 into master Nov 11, 2024
16 checks passed
@bkoelman bkoelman deleted the jsonapi-extensions-refactor branch November 11, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant