Request with query string '=' returns 500

[verdie-g]

DESCRIPTION

curl 'http://localhost:5000/people?='

returns

{
  "links": {
    "self": "http://localhost:5065/people?="
  },
  "errors": [
    {
      "id": "76871a51-79fc-46ba-848b-f8027f5a03ed",
      "status": "500",
      "title": "An unhandled error occurred while processing this request.",
      "detail": "String cannot be null or empty. (Parameter 'parameterName')"
    }
  ]
}

STEPS TO REPRODUCE

1. Follow https://www.jsonapi.net/getting-started/step-by-step.html
2. Run curl 'http://localhost:5000/people?='

EXPECTED BEHAVIOR

A proper 4XX explaining the problem.

ACTUAL BEHAVIOR

A 500.

[bkoelman]

What's the stack trace?

[verdie-g]

System.ArgumentException: String cannot be null or empty. (Parameter 'parameterName')
         at void JsonApiDotNetCore.ArgumentGuard.NotNullNorEmpty(string value, string parameterName) in /_/src/JsonApiDotNetCore.Annotations/ArgumentGuard.cs:line 36
         at bool JsonApiDotNetCore.QueryStrings.FilterQueryStringParameterReader.CanRead(string parameterName) in /_/src/JsonApiDotNetCore/QueryStrings/FilterQueryStringParameterReader.cs:line 53
         at void JsonApiDotNetCore.QueryStrings.QueryStringReader.ReadAll(DisableQueryStringAttribute disableQueryStringAttribute)+(IQueryStringParameterReader nextReader) => { } in /_/src/JsonApiDotNetCore/QueryStrings/QueryStringReader.cs:line 41
         at TSource System.Linq.Enumerable.TryGetFirst<TSource>(IEnumerable<TSource> source, Func<TSource, bool> predicate, out bool found)
         at TSource System.Linq.Enumerable.FirstOrDefault<TSource>(IEnumerable<TSource> source, Func<TSource, bool> predicate)
         at void JsonApiDotNetCore.QueryStrings.QueryStringReader.ReadAll(DisableQueryStringAttribute disableQueryStringAttribute) in /_/src/JsonApiDotNetCore/QueryStrings/QueryStringReader.cs:line 41
         at async Task JsonApiDotNetCore.Middleware.AsyncQueryStringActionFilter.OnActionExecutionAsync(ActionExecutingContext context, ActionExecutionDelegate next) in /_/src/JsonApiDotNetCore/Middleware/AsyncQueryStringActionFilter.cs:line 29
         at async Task Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeNextActionFilterAsync()+Awaited(?)
         at void Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
         at Task Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(ref State next, ref Scope scope, ref object state, ref bool isCompleted)
         at Task Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeInnerFilterAsync()
         at async Task Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeNextExceptionFilterAsync()+Awaited(?)

[bkoelman]

Thanks. Looks like QueryStringReader needs to skip over empty parameter names. Do you want to submit a PR?