Review feedback

Author: Bart Koelman

src/JsonApiDotNetCore/Configuration/JsonApiValidationFilter.cs

@@ -25,7 +25,7 @@ public JsonApiValidationFilter(IHttpContextAccessor httpContextAccessor)
         /// <inheritdoc />
         public bool ShouldValidateEntry(ValidationEntry entry, ValidationEntry parentEntry)
         {
-            IServiceProvider serviceProvider = GetServiceProvider();
+            IServiceProvider serviceProvider = GetScopedServiceProvider();
 
             var request = serviceProvider.GetRequiredService<IJsonApiRequest>();
 
@@ -50,7 +50,7 @@ public bool ShouldValidateEntry(ValidationEntry entry, ValidationEntry parentEnt
             return true;
         }
 
-        private IServiceProvider GetServiceProvider()
+        private IServiceProvider GetScopedServiceProvider()
         {
             HttpContext httpContext = _httpContextAccessor.HttpContext;
 

src/JsonApiDotNetCore/Serialization/Request/Adapters/JsonElementConstraint.cs

@@ -9,12 +9,12 @@ namespace JsonApiDotNetCore.Serialization.Request.Adapters
     public enum JsonElementConstraint
     {
         /// <summary>
-        /// A value for the field is not allowed.
+        /// A value for the element is not allowed.
         /// </summary>
         Forbidden,
 
         /// <summary>
-        /// A value for the field is required.
+        /// A value for the element is required.
         /// </summary>
         Required
     }

src/JsonApiDotNetCore/Serialization/Request/Adapters/ResourceDataAdapter.cs

@@ -33,7 +33,7 @@ public IIdentifiable Convert(SingleOrManyData<ResourceObject> data, ResourceIden
 
             (IIdentifiable resource, ResourceType _) = ConvertResourceObject(data, requirements, state);
 
-            // Ensure that IResourceDefinition extensibility point sees the current operation, it case it injects IJsonApiRequest.
+            // Ensure that IResourceDefinition extensibility point sees the current operation, in case it injects IJsonApiRequest.
             state.RefreshInjectables();
 
             _resourceDefinitionAccessor.OnDeserialize(resource);

src/JsonApiDotNetCore/Serialization/Request/Adapters/ResourceIdentityAdapter.cs

@@ -32,13 +32,13 @@ protected ResourceIdentityAdapter(IResourceGraph resourceGraph, IResourceFactory
             ArgumentGuard.NotNull(requirements, nameof(requirements));
             ArgumentGuard.NotNull(state, nameof(state));
 
-            ResourceType resourceType = ConvertType(identity, requirements, state);
+            ResourceType resourceType = ResolveType(identity, requirements, state);
             IIdentifiable resource = CreateResource(identity, requirements, resourceType.ClrType, state);
 
             return (resource, resourceType);
         }
 
-        private ResourceType ConvertType(IResourceIdentity identity, ResourceIdentityRequirements requirements, RequestAdapterState state)
+        private ResourceType ResolveType(IResourceIdentity identity, ResourceIdentityRequirements requirements, RequestAdapterState state)
         {
             AssertHasType(identity, state);