Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Django's built in RedisCache cache backend #283

Open
pawelad opened this issue Feb 2, 2023 · 1 comment
Open

Support for Django's built in RedisCache cache backend #283

pawelad opened this issue Feb 2, 2023 · 1 comment

Comments

@pawelad
Copy link

pawelad commented Feb 2, 2023

Hi!

Django 4.0 was released with a built in RedisCache cache backend (https://docs.djangoproject.com/en/4.1/topics/cache/#redis). As far as I understand, it's a simpler (and built in) alternative to django-redis (jazzband/django-redis#585)

I noticed today that I get a (django_ratelimit.W001) cache backend django.core.cache.backends.redis.RedisCache is not officially supported warning when using it with django-ratelimit. Is that on purpose? Would you be open to adding it to the list of SUPPORTED_CACHE_BACKENDS ? Would that need some extra checks / tests / CI changes?

I'm happy to help with this with a PR.

@jaap3
Copy link
Contributor

jaap3 commented Oct 8, 2024

I just stumbled upon this and was wondering why I've never seen this check pop up. Turns out that I never added django-ratelimit to INSTALLED_APPS. As far as I can tell it still works as intended. The only thing that happens when it is in installed apps is the registration of this check. Alternatively add django_ratelimit.W001 to settings.SILENCED_SYSTEM_CHECKS in your project and wait until @jsocol or someone else updates the list of SUPPORTED_CACHE_BACKENDS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants