Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_kinova_robot] Update README for noetic #1906

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Kanazawanaoaki
Copy link
Contributor

@Kanazawanaoaki Kanazawanaoaki commented Feb 4, 2024

The README has been updated with the modifications for building the jsk_kinova_robot environment in Noetic, as reported in #1905.

jsk_kinova_robot/README.md Outdated Show resolved Hide resolved
@@ -69,9 +69,10 @@ mkdir -p ~/kinova_ws/src
cd ~/kinova_ws/src
wstool init
wstool merge https://raw.githubusercontent.com/jsk-ros-pkg/jsk_robot/master/jsk_kinova_robot/kinova.rosinstall
wstool merge https://raw.githubusercontent.com/Kanazawanaoaki/jsk_robot/kinova-noetic/jsk_kinova_robot/kinova.rosinstall.${ROS_DISTRO} # Please ignore error if kinova.rosinstall.${ROS_DISTRO} does not exist. # We can remove this line after the https://github.com/ros/collada_urdf/pull/44 is merged
Copy link
Member

@mqcmd196 mqcmd196 Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is okay with like
https://raw.githubusercontent.com/jsk-ros-pkg/jsk_robot/master/jsk_kinova_robot/kinova.rosinstall.${ROS_DISTRO}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it. 6022d95

wstool update
cd ../
source /opt/ros/melodic/setup.bash
source /opt/ros/${ROS_DISTRO}/setup.bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NITS: The environment variable ${ROS_DISTRO} has not been set unless the user source /opt/ros/.../setup.bash . So you had better writing like /opt/ros/noetic/setup.bash # If noetic

Copy link
Contributor Author

@Kanazawanaoaki Kanazawanaoaki Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put source /opt/ros/*/setup.bash first because .rosinstall part also uses ${ROS_DISTRO}. 6193b0f

Copy link
Member

@mqcmd196 mqcmd196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants