➖ remove dependency on node:path; reinvent wheel #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctcpip
commented
Mar 27, 2025
| let filenameIndex = 0 | ||
|
|
||
| // find last / | ||
| for (let i = path.length - 1; i >= 0; i--) { |
Member
Author
There was a problem hiding this comment.
all this can be done more elegantly, but at a cost to perf
|
It will help to fix #157 |
Member
|
@ctcpip let me know if you want me to include this in the next release 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #111
(potentially)
I'm not a huge fan of reinventing the wheel here, but it's one possible solution