Add test for extending native errors w/o altering prototype#106
Merged
jonchurch merged 4 commits intojshttp:masterfrom Feb 5, 2025
Merged
Conversation
Contributor
|
This change looks good to me. |
carpasse
approved these changes
May 8, 2024
wesleytodd
approved these changes
Jul 11, 2024
UlisesGascon
approved these changes
Jul 13, 2024
looking at this ci again, idk why it even passed under old node versions that dont support const, seems sus
bjohansebas
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test to assert on behavior outlined in the docs but not captured in the test suite.
https://github.com/jshttp/http-errors?tab=readme-ov-file#createerrorstatus-error-properties