Skip to content

Raise minimum Node.js version to v20 #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

asamuzaK
Copy link
Contributor

@asamuzaK asamuzaK commented Jul 12, 2025

  • .github/workflows/build.yml
    Drop node v18 and add node v22 as lts/*
  • package.json
    Bump engines.node to >=20
  • lib/properties/font.js
    Switch to Array.prototype.toReversed()
  • scripts/generateImplementedProperties.mjs
    • Switch to import.meta.dirname
    • Sort generated properties

Done below

TODO:
Fix properties/font.js after #227 get merged.

TBD:
Should we fix scripts/generateImplementedProperties.mjs too?
However, import.meta.dirname is not standard.

@asamuzaK asamuzaK marked this pull request as draft July 12, 2025 01:03
@asamuzaK asamuzaK changed the title Drop node v18 and add node v22 as lts/* Raise minimum Node.js version to v18 Jul 12, 2025
@asamuzaK asamuzaK changed the title Raise minimum Node.js version to v18 Raise minimum Node.js version to v20 Jul 12, 2025
@domenic
Copy link
Member

domenic commented Jul 12, 2025

TBD:
Should we fix scripts/generateImplementedProperties.mjs too?
However, import.meta.dirname is not standard.

I think we should fix it. import.meta is not governed by standards, so since we are running on Node.js, we can use anything that they officially support. Per https://nodejs.org/api/esm.html#importmetadirname import.meta.dirname is officially supported.

@asamuzaK asamuzaK marked this pull request as ready for review July 12, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants