Skip to content

fix background-* spelling #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

fix background-* spelling #215

merged 2 commits into from
Jun 20, 2025

Conversation

fshowalter
Copy link
Contributor

Closes #214

@asamuzaK
Copy link
Contributor

asamuzaK commented Jun 8, 2025

Thanks for the catch.
Please add regression test at the end of test/CSSDeclaration.test.js:

describe("regression test for https://github.com/jsdom/cssstyle/issues/214", () => {
  it("should return value for each property", () => {
    const style = new CSSStyleDeclaration();
    const key = "background-color";
    const camel = "backgroundColor";
    const value = "var(--foo)";
    style[key] = value;
    assert.strictEqual(style[key], value);
    style[key] = null;
    style[camel] = value;
    assert.strictEqual(style[camel], value);
  });
});

@fshowalter
Copy link
Contributor Author

fshowalter commented Jun 9, 2025

Done. As an alternative, have you considered adding a cspell lint stage?

@RSS1102
Copy link

RSS1102 commented Jun 10, 2025

Done. As an alternative, have you considered adding a cspell lint stage?

use typos

@liweijie0812
Copy link

ci spelling check #216

@domenic domenic merged commit 7433b10 into jsdom:main Jun 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background properites misnamed as "backgound" (missing the 'r')
5 participants