Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL and CA problem #130

Open
PerfectLiang opened this issue Sep 13, 2024 · 3 comments
Open

SSL and CA problem #130

PerfectLiang opened this issue Sep 13, 2024 · 3 comments

Comments

@PerfectLiang
Copy link

PerfectLiang commented Sep 13, 2024

Can we add free TLS config to avoid SSL and CA problem

func NewClient(config Config) Client {
return &client{
http: &http.Client{
// Transport: &http.Transport{
// TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
// },
Timeout: 30 * time.Second,
},
apiURL: config.APIURL,
apiToken: config.APIToken,
userAgent: config.UserAgent,
cache: map[string]*CacheEntry{},
}
}

@radulucut
Copy link
Collaborator

We'll add the option to set a custom http client through the config.

I think it would be a better idea to append the cert to the root CAs instead of using InsecureSkipVerify.

@PerfectLiang
Copy link
Author

good idea, thx

@MartinKolarik
Copy link
Member

@radulucut I'm not sure, is there anything we still need to do here? If yes, in what scenarios does it apply?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants