We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we add free TLS config to avoid SSL and CA problem
func NewClient(config Config) Client { return &client{ http: &http.Client{ // Transport: &http.Transport{ // TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, // }, Timeout: 30 * time.Second, }, apiURL: config.APIURL, apiToken: config.APIToken, userAgent: config.UserAgent, cache: map[string]*CacheEntry{}, } }
The text was updated successfully, but these errors were encountered:
We'll add the option to set a custom http client through the config.
I think it would be a better idea to append the cert to the root CAs instead of using InsecureSkipVerify.
InsecureSkipVerify
Sorry, something went wrong.
good idea, thx
@radulucut I'm not sure, is there anything we still need to do here? If yes, in what scenarios does it apply?
No branches or pull requests
Can we add free TLS config to avoid SSL and CA problem
func NewClient(config Config) Client {
return &client{
http: &http.Client{
// Transport: &http.Transport{
// TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
// },
Timeout: 30 * time.Second,
},
apiURL: config.APIURL,
apiToken: config.APIToken,
userAgent: config.UserAgent,
cache: map[string]*CacheEntry{},
}
}
The text was updated successfully, but these errors were encountered: