Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ie7 bugs #17

Open
ghost opened this issue May 21, 2013 · 6 comments
Open

ie7 bugs #17

ghost opened this issue May 21, 2013 · 6 comments

Comments

@ghost
Copy link

ghost commented May 21, 2013

I am not asking for support for the animations, but the library itself causes a js error when loaded in compatibility mode, ie7 standards in IE10. The bulk of it seems its from using .in as an object property since it is a reserved javascript keyword. Even if i change the .in to ['in'], http://code.jquery.com/jquery-1.9.1.js seems to have an issue loading at line 2582 saying member not found. Would be great to clean up the code and address these issues to at least make it load in older browsers. Thanks.

@jschr
Copy link
Owner

jschr commented May 22, 2013

Interesting, I definitely would have thought ['in'] would work. Obviously I did not do much testing in older browsers but I agree it should be able to load the library.

@ghost
Copy link
Author

ghost commented May 22, 2013

If I have time this weekend I'll try and submit a pull request.

@yuhaoboris
Copy link

i changed 'in' to '_in', it works on IE8 and 7

@aapljack
Copy link

aapljack commented Oct 3, 2013

This seems to still be an issue. I tested it in IE8. Wasn't working.

To get around it, I changed the defaults in jquery.textillate.js to my custom options. This prevented me from having to call 'in' in the jquery block of my document.

@rll6976
Copy link

rll6976 commented Apr 30, 2014

Having same issue in IE8 with "in". Any chances next release coming soon?

@VaelVictus
Copy link

Chiming in (!) here to say you can change in to _in as suggested. In your call code, reference _in: and in the textillate.js itself, go to line 149 (for me) and see:

if (isInEffect(options.in.effect)) {

Yes, change .in. to ._in. there.

Two lines down, do it again. And finally,
animateChars($chars, options.in, function () {

As well. Very quick change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants