Always lookup the security token

[jschneier]

No description provided.

[codecov-io]

Codecov Report

Merging #370 into master will decrease coverage by 0.27%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage   76.05%   75.77%   -0.28%     
==========================================
  Files          11       11              
  Lines        1566     1548      -18     
==========================================
- Hits         1191     1173      -18     
  Misses        375      375

Impacted Files	Coverage Δ
storages/backends/s3boto3.py	86.46% <100%> (-0.09%)	⬇️
storages/backends/s3boto.py	87.37% <100%> (-0.05%)	⬇️
storages/backends/dropbox.py	97.36% <0%> (-0.44%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adefe32...cda5f52. Read the comment docs.

[aarcro]

I would follow the established pattern of pulling in values from the Django settings to avoid extra os.environ lookups.

[aarcro]

This will be less surprising and broken. So that setting KEY_ID and SECRET in settings.py doesn't prevent the ability to use the TOKEN.

BUT, I would set security_token at line 180 following the same pattern as access_key and secret_key

[jschneier]

Agreed

…

On Jul 28, 2017, at 15:46, Aaron McMillin ***@***.***> wrote: @aarcro requested changes on this pull request. I would follow the established pattern of pulling in values from the Django settings to avoid extra os.environ lookups. In storages/backends/s3boto.py: > @@ -238,10 +238,9 @@ def __init__(self, acl=None, bucket=None, **settings): self._connection = None self._loaded_meta = False - self.security_token = None + self.security_token = self._get_security_token() This will be less surprising and broken. So that setting KEY_ID and SECRET in settings.py doesn't prevent the ability to use the TOKEN. BUT, I would set security_token at line 180 following the same pattern as access_key and secret_key — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.