Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud Storage backend using the gcloud-python library #146

Closed
wants to merge 1 commit into from
Closed

Conversation

eirsyl
Copy link
Contributor

@eirsyl eirsyl commented Apr 27, 2016

This is kind a work in progress and is just a proposal. Is a Google Cloud Storage backend using gcloud-python something this project needs?

The gcloud-python package supports multiple types of authentication:

  • Application running in Google App Engine
  • JSON or PKCS12/P12 keyfile pointed to by GOOGLE_APPLICATION_CREDENTIALS environment variable
  • Credentials provided by the Google Cloud SDK (via gcloud auth login)
  • Application running in Google Compute Engine

The code is not perfect and needs some small changes before production. Any thoughts on this?

@codecov-io
Copy link

codecov-io commented Apr 27, 2016

Current coverage is 27.55%

Merging #146 into master will decrease coverage by -3.50%

@@             master       #146   diff @@
==========================================
  Files            17         18     +1   
  Lines          1298       1463   +165   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            403        403          
- Misses          895       1060   +165   
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by f210da0

@scjody
Copy link
Contributor

scjody commented Dec 13, 2016

@eirsyl I'm interested in this and may have some time to contribute towards getting this mergeable. What's on the TODO list other than improving test coverage?

There are a couple of other ways to use Google Cloud Storage as a Django storage backend, but neither of them are great:

  • django-storages supports libcloud, which can access Google Cloud Storage but only in S3 compatibility mode. S3 compatibility mode is only designed for use during short term migrations, and requires per-developer keys that don't allow fine-grained access control.
  • https://pypi.python.org/pypi/django-gcloud-storage says it's an alpha and explicitly warns against using it in production.

@eirsyl
Copy link
Contributor Author

eirsyl commented Dec 13, 2016

The first draft is heavily inspired by the S3 implementation, we should probably spend some time understanding the gcloud library to make this implementation right. An like you said, tests and documentation is also a required to make this mergable.

@scjody
Copy link
Contributor

scjody commented Dec 13, 2016

OK, I'll read up on the gcloud library and review the code with that in mind. I'm in the middle of another major project but I can work on this when that's blocked.

@scjody
Copy link
Contributor

scjody commented Dec 14, 2016

Interestingly, there's also gs.py. I can't find any documentation for it, and it seems to require S3 compatibility mode so I can't use it in any case.

@scjody
Copy link
Contributor

scjody commented Dec 14, 2016

I had to rename the module and change the imports since Google renamed their library. I'm working on my own PR since I don't see a way to collaborate on this one.

@eirsyl
Copy link
Contributor Author

eirsyl commented Jan 5, 2017

Closing this in favor of #236

@eirsyl eirsyl closed this Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants