Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix of issues #137 and issue #138 #140

Closed
wants to merge 1 commit into from
Closed

Fix of issues #137 and issue #138 #140

wants to merge 1 commit into from

Conversation

epetxepe
Copy link

@epetxepe
Fix of issues jschneier#137 and issue jschneier#138
c51f3b6 
- jschneier#137 I've placed everything on the _save function given that "get_available_name" was not being called when file is written with open () method.
- jschneier#138 No file_overwrite variable is considered. Overwrite is forced, if the file has the same content, dropbox keeps the previous one so no overwrite is reflected.
@zkhan93
Copy link

zkhan93 commented Apr 15, 2017

I am using v1.5.2, facing #137 what should I do? I think this pull request should be merged.

@jschneier
Copy link
Owner

jschneier commented Apr 15, 2017 •
edited
Loading

@zkhan93 I just pushed a fix to #137, can you try out master?

@jschneier
Copy link
Owner

@zkhan93 that is, install from git as is covered in the README.

@zkhan93
Copy link

zkhan93 commented Apr 16, 2017

@jschneier it is working fine thanks 👍

@sww314
Copy link
Contributor

sww314 commented Jul 11, 2018

Closing stale requests.

@sww314 sww314 closed this Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@epetxepe @zkhan93 @jschneier @sww314