Add GCloud parameters as kwargs for storage.url #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fao89
changed the title
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Oct 28, 2022
ref: jschneier/django-storages#1193 [noissue]
fao89
added a commit
to fao89/pulp_container
that referenced
this pull request
Oct 28, 2022
jschneier/django-storages#1193 Required PR: pulp/pulpcore#3367 [noissue]
fao89
added a commit
to fao89/pulp_container
that referenced
this pull request
Oct 28, 2022
jschneier/django-storages#1193 Required PR: pulp/pulpcore#3367 [noissue]
fao89
added a commit
to fao89/pulp-operator
that referenced
this pull request
Oct 28, 2022
|
@jschneier PTAL |
|
This looks generally fine, it doesn't allow people to override |
It enables using kwargs, such as `content_type` https://cloud.google.com/python/docs/reference/storage/latest/google.cloud.storage.blob.Blob#google_cloud_storage_blob_Blob_generate_signed_url
@jschneier I've addressed your comment, could you please take another look? |
|
Looks good, thanks. |
|
@jschneier do you have an idea when it will be released? |
This was referenced Nov 22, 2022
This was referenced Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It enables using kwargs, such as
content_typehttps://cloud.google.com/python/docs/reference/storage/latest/google.cloud.storage.blob.Blob#google_cloud_storage_blob_Blob_generate_signed_urlRef: #1071