Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AWS_DEFAULT_ACL to 'private' #381

Closed
jonashaag opened this issue Aug 14, 2017 · 4 comments
Closed

Change AWS_DEFAULT_ACL to 'private' #381

jonashaag opened this issue Aug 14, 2017 · 4 comments
Labels

Comments

@jonashaag
Copy link

  1. For obvious security reasons
  2. Because it doesn't work out of the box with the default S3 tutorial (which doesn't grant publish permissions), with no good error message ("Access Denied", where a good message would be "Access to make file public-read denied")
@jschneier
Copy link
Owner

I agree, will have to go in a 2.0 release. I've been lax about breaking changes because they are usually smaller and not in widely used backends. This would not be that in any way.

@jschneier jschneier modified the milestone: 1.2 Aug 14, 2017
@robatwave
Copy link

robatwave commented Sep 25, 2017

By default it shouldn't set ACL at all (boto's default behaviour), and defer to the bucket's ACL? Or as a non-breaking change, there should be an option to not explicitly set an ACL on the object. That way you could give an application's IAM role PutObject without having to also give it PutObjectAcl.

@robatwave
Copy link

Just to follow up: looks like we can work around this by explicitly setting AWS_DEFAULT_ACL to None in settings.

@jschneier
Copy link
Owner

We will now warn about the insecure defaults with a recommendation to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants