Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Build and Test steps in CI. #201

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

12wrigja
Copy link
Contributor

@12wrigja 12wrigja commented Dec 8, 2022

Make use of reusable GitHub workflows and matrix testing strategies.

@justingrant
Copy link
Contributor

I admit I don't fully understand what this PR is doing. Where did Test262 runs go?

@12wrigja
Copy link
Contributor Author

12wrigja commented Dec 8, 2022

I haven't finished work on this - I was just pushing it to see what the GitHub CI does. The idea was the split all the execution of build steps and testing steps so that builds would only ever be run using newer versions of Node, while testing against the artifacts could then use older versions. I realized later this doesn't make sense for Demitasse tests, as those don't actually build using Rollup (using Node), they only need transpilation to succeed (and are then executed by a particular Node version that reads the transpiled library sources along with the test sources).
After the changes in #202 I don't think this exact structure is necessary (though something similar might be a good cleanup just to reduce the duplication within our workflows).

I commented out the test262 runs temporarily because I though it was causing GH to think the workflow file was broken (there's some weird edge-cases where you get no feedback about this either in the GH UI or in the project-wide actions/workflows UI).

@justingrant
Copy link
Contributor

Is this PR still relevant given the other changes we made to use matrix tasks in CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants