-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Build and Test steps in CI. #201
base: main
Are you sure you want to change the base?
Conversation
Make use of reusable GitHub workflows and matrix testing strategies.
…nd Test steps in CI.
…Build and Test steps in CI.
… Split Build and Test steps in CI.
… fixup! Split Build and Test steps in CI.
… fixup! fixup! Split Build and Test steps in CI.
I admit I don't fully understand what this PR is doing. Where did Test262 runs go? |
I haven't finished work on this - I was just pushing it to see what the GitHub CI does. The idea was the split all the execution of build steps and testing steps so that builds would only ever be run using newer versions of Node, while testing against the artifacts could then use older versions. I realized later this doesn't make sense for Demitasse tests, as those don't actually build using Rollup (using Node), they only need transpilation to succeed (and are then executed by a particular Node version that reads the transpiled library sources along with the test sources). I commented out the test262 runs temporarily because I though it was causing GH to think the workflow file was broken (there's some weird edge-cases where you get no feedback about this either in the GH UI or in the project-wide actions/workflows UI). |
Is this PR still relevant given the other changes we made to use matrix tasks in CI? |
Make use of reusable GitHub workflows and matrix testing strategies.