Skip to content

Support Markdown-style links in PR template URL check #9883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2025

Conversation

raman976
Copy link
Contributor

@raman976 raman976 commented Jun 20, 2025

  • There is reasonable content on the page
  • I have read and accepted the Terms and Conditions
  • The site content can be seen at Test

The site content is a test placeholder to satisfy the CI.


Summary

Fixes #9858 – Enhances the urlLineRegex in the GitHub Actions workflow to support Markdown-formatted URLs in PR templates, including:

  • <https://example.com> (angle-bracketed)
  • [My Site](https://example.com) (Markdown-style link)

This change improves the flexibility and accuracy of the PR template validation check in CI.

@MattIPv4
Copy link
Member

Oh, you'll want to have your PR description still have the expected content for the check ;)

Co-authored-by: Matt Cowley <me@mattcowley.co.uk>
@MattIPv4 MattIPv4 added enhancement CI IMP opportunity to improve CI labels Jun 20, 2025
@MattIPv4 MattIPv4 changed the title fix(ci): support Markdown-style links in PR template URL check Support Markdown-style links in PR template URL check Jun 20, 2025
@raman976
Copy link
Contributor Author

Thanks a lot for the approval! Just wanted to kindly ping in case this PR got missed for merging. Let me know if anything else is needed from my side.

@indus indus merged commit 5025fd3 into js-org:master Jun 21, 2025
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI IMP opportunity to improve CI enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Markdown links in PR template URL check
3 participants