Skip to content

nostalgist.js.org #8567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2023
Merged

nostalgist.js.org #8567

merged 1 commit into from
Oct 12, 2023

Conversation

arianrhodsandlot
Copy link
Contributor

MattIPv4
MattIPv4 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/arianrhodsandlot/nostalgist/tree/docs/docs/src/content/docs

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Oct 10, 2023
@indus indus added the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Oct 11, 2023
@indus
Copy link
Member

indus commented Oct 11, 2023

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@arianrhodsandlot
Copy link
Contributor Author

@indus It works now. Thank you very much 🙏.

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Oct 12, 2023
@indus
Copy link
Member

indus commented Oct 12, 2023

Welcome https://nostalgist.js.org

@indus indus merged commit bdf4919 into js-org:master Oct 12, 2023
@arianrhodsandlot arianrhodsandlot deleted the patch-1 branch October 12, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arianrhodsandlot @indus @MattIPv4