Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e-query.js.org #8559

Merged
merged 1 commit into from
Oct 6, 2023
Merged

e-query.js.org #8559

merged 1 commit into from
Oct 6, 2023

Conversation

mjkhonline
Copy link
Contributor

@mjkhonline mjkhonline commented Oct 5, 2023

@MattIPv4 MattIPv4 changed the title add e-query e-query.js.org Oct 5, 2023
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Oct 5, 2023
@mjkhonline
Copy link
Contributor Author

mjkhonline commented Oct 5, 2023

Thanks for your quick response.

DONE ✅

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/mjkhonline/e-query/tree/main/docs

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Oct 5, 2023
@mjkhonline
Copy link
Contributor Author

@MattIPv4 hey buddy.
Do you think how long does it take?
I sudspended publish of my package for this change.
Many thanks.

@indus
Copy link
Member

indus commented Oct 6, 2023

I've just added your requested subdomain to JS.ORGs zonefile. But as you are using a workflow to deploy the page there may be other steps involved to get the CNAME working. FYI: #7853 (comment) / #8532 (comment)

@mjkhonline
Copy link
Contributor Author

I've just added your requested subdomain to JS.ORGs zonefile. But as you are using a workflow to deploy the page there may be other steps involved to get the CNAME working. FYI: #7853 (comment) / #8532 (comment)

Thanks :)
It worked. Now the site is up ✅

@indus
Copy link
Member

indus commented Oct 6, 2023

Welcome https://e-query.js.org

@indus indus merged commit 2eadef1 into js-org:master Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants