Skip to content

dreamcord.js.org #8548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2023
Merged

dreamcord.js.org #8548

merged 1 commit into from
Oct 1, 2023

Conversation

ToastedDev
Copy link
Contributor

https://dreamcordjs.github.io/dreamcord

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Sep 30, 2023
@ToastedDev
Copy link
Contributor Author

ToastedDev commented Sep 30, 2023

Got it. I've added the domain on GitHub Pages.

@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account labels Sep 30, 2023
@indus
Copy link
Member

indus commented Sep 30, 2023

I've already added your requested subdomain to JS.ORGs zonefile. But in case you are using a workflow to deploy the page there may be other steps involved to get the CNAME working. FYI: #7853 (comment) / #8532 (comment)

@ToastedDev
Copy link
Contributor Author

The domain seems to already work (at least on my machine).

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Oct 1, 2023
@indus
Copy link
Member

indus commented Oct 1, 2023

Welcome https://dreamcord.js.org

@indus indus merged commit 37f07a4 into js-org:master Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants