fix load error: jopenssl/load -- java.lang.VerifyError: Bad type on operand stack when using bouncycastle 1.51 or 1.52

[cheister]

This should fix #4

In BouncyCastle 1.51 they changed the hierarchy of ASN1ObjectIdentifier so it is a parent of DERObjectIdentifier instead of a descendant of it. In the code, if we pass a string id instead of the ASN1ObjectIdentifier object then BouncyCastle will create the correct ASN1ObjectIdentifier object.

[kares]

thanks we'd appreciate a test-case esp. as we might still need to support at least BC 1.50 (> 1.50 was not fully really reviewed yet - not sure what's missing hopefully not match) and this might break older versions

[cheister]

You can reproduce the error if you run mvn verify -P test-1.7.19 -Dbc.versions=1.51 or mvn verify -P test-1.7.19 -Dbc.versions=1.52.

mvn verify -P test-1.7.19 -Dbc.versions=1.50 passes with this change

It would be very surprising if this broke previous versions since the X509V3CertificateGenerator.addExtension(String, boolean, ASN1Encodable) method is just delegating to the X509V3CertificateGenerator.addExtension(DERObjectIdentifier, boolean, ASN1Encodable) method in 1.50 and the X509V3CertificateGenerator.addExtension(ASN1ObjectIdentifier, boolean, ASN1Encodable) in 1.51 and 1.52. https://github.com/bcgit/bc-java/blob/master/prov/src/main/java/org/bouncycastle/x509/X509V3CertificateGenerator.java#L225

[kares]

understood, thanks for explaining this further.