display and parse inconsistency with DNS SubjectAltNames #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As soon as a certificate has more than one (DNS?) SAN, jruby-openssl a) represents them internally as multiple extensions b) the `to_text` also renders them as multiple entries However, as far as I understand https://tools.ietf.org/html/rfc5280#section-4.2 an extension MUST only appear once: "A certificate MUST NOT include more than one instance of a particular extension.", which means that the representation like it is now is at least misleading, if not even completely wrong. MRI openssl returns for the same certificate only one extension, matching a string that is also expected in the other SAN test case. This especially breaks any kind of client tools that are looking for the *first* extension and then try to match that content. Also the test shows an inconsistency before and after parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As soon as a certificate has more than one (DNS?) SAN, jruby-openssl
a) represents them internally as multiple extensions
b) the
to_textalso renders them as multiple entriesHowever, as far as I understand https://tools.ietf.org/html/rfc5280#section-4.2
an extension MUST only appear once: "A certificate MUST NOT include
more than one instance of a particular extension.", which means
that the representation like it is now is at least misleading,
if not even completely wrong. MRI openssl returns for the same
certificate only one extension, matching a string that is also
expected in the other SAN test case.
This especially breaks any kind of client tools that are looking
for the first extension and then try to match that content.
Also the test shows an inconsistency before and after parsing.