Merge pull request #110 from iconara/no-warnings-on-missing-client-cert

kares · web-flow · commit bf9420c5c607 · 2016-10-26T11:08:37.000+02:00
Don't print a warning for missing client certs
diff --git a/src/main/java/org/jruby/ext/openssl/SSLSocket.java b/src/main/java/org/jruby/ext/openssl/SSLSocket.java
@@ -958,7 +958,7 @@ public IRubyObject peer_cert() {
             throw X509Cert.newCertificateError(runtime, e);
         }
         catch (SSLPeerUnverifiedException e) {
-            if (runtime.isVerbose() || OpenSSL.isDebug(runtime)) {
+            if (OpenSSL.isDebug(runtime)) {
                 runtime.getWarnings().warning(String.format("%s: %s", e.getClass().getName(), e.getMessage()));
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -958,7 +958,7 @@ public IRubyObject peer_cert() {`
`958`	`958`	`throw X509Cert.newCertificateError(runtime, e);`
`959`	`959`	`}`
`960`	`960`	`catch (SSLPeerUnverifiedException e) {`
`961`		`- if (runtime.isVerbose() \|\| OpenSSL.isDebug(runtime)) {`
	`961`	`+ if (OpenSSL.isDebug(runtime)) {`
`962`	`962`	`runtime.getWarnings().warning(String.format("%s: %s", e.getClass().getName(), e.getMessage()));`
`963`	`963`	`}`
`964`	`964`	`}`