Merge pull request #3 from dina/patch-1

kares · kares · commit aedd91ad83e3 · 2014-07-29T21:59:51.000+02:00
Throw error when chain certs are *not* OpenSSL::X509::Certificate
diff --git a/src/main/java/org/jruby/ext/openssl/SSLContext.java b/src/main/java/org/jruby/ext/openssl/SSLContext.java
@@ -570,7 +570,7 @@ private X509Cert[] convertToX509Certs(final ThreadContext context, IRubyObject v
 
                 public IRubyObject call(ThreadContext context, IRubyObject[] args, Block block) {
                     final IRubyObject cert = args[0];
-                    if ( _Certificate.isInstance(cert) ) {
+                    if ( ! ( _Certificate.isInstance(cert) ) ) {
                         throw context.runtime.newTypeError("wrong argument : " + cert.inspect() + " is not a " + _Certificate.getName());
                     }
                     result.add((X509Cert) cert);

Original file line number	Diff line number	Diff line change
`@@ -570,7 +570,7 @@ private X509Cert[] convertToX509Certs(final ThreadContext context, IRubyObject v`
`570`	`570`
`571`	`571`	`public IRubyObject call(ThreadContext context, IRubyObject[] args, Block block) {`
`572`	`572`	`final IRubyObject cert = args[0];`
`573`		`- if ( _Certificate.isInstance(cert) ) {`
	`573`	`+ if ( ! ( _Certificate.isInstance(cert) ) ) {`
`574`	`574`	`throw context.runtime.newTypeError("wrong argument : " + cert.inspect() + " is not a " + _Certificate.getName());`
`575`	`575`	`}`
`576`	`576`	`result.add((X509Cert) cert);`