Skip to content

Commit 5cef741

Browse files
authored
Merge pull request #17 from monkstone/patch-2
Patch 2
2 parents 5908547 + ebda489 commit 5cef741

File tree

3 files changed

+34
-7
lines changed

3 files changed

+34
-7
lines changed

extensions/basic/README.md

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,39 @@ This project aims to demo small and easy concepts around jruby extensions, this
1515
Or for the impatient
1616

1717
```bash
18-
mvn # builds basic.jar
18+
mvn # builds basic.jar in target folder
1919
```
2020

2121
```bash
2222
mvn javadoc:javadoc # javadoc
2323
```
2424

25+
For jdk-11+ replace
26+
27+
```ruby
28+
source: '${maven.compiler.source}',
29+
target: '${maven.compiler.target}'
30+
```
31+
32+
with
33+
34+
```ruby
35+
release: '${maven.compiler.release}'
36+
```
37+
You may also wish to replace insertion of a manual Manifest, with an automatic module viz:
38+
39+
```ruby
40+
plugin(:jar, '3.2.0',
41+
'archive' => {
42+
'manifestEntries' => {
43+
'Automatic-Module-Name' => '${my.module}'
44+
}
45+
})
46+
```
47+
48+
49+
50+
2551
[polyglot maven]:https://github.com/takari/polyglot-maven
2652
[wiki]:https://github.com/jruby/jruby/wiki/Method-Signatures-and-Annotations-in-JRuby-extensions
2753
[guide]:https://github.com/jruby/jruby/wiki/Java-extensions-for-JRuby-using-polyglot-maven

extensions/basic/jruby-ext/pom.rb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
project 'jruby-ext' do
22

33
model_version '4.0.0'
4-
id 'com.purbon:jruby-ext:1.2.2'
4+
id 'com.purbon:jruby-ext:1.3.0'
55
packaging 'jar'
66

77
description 'example JRuby extension'
@@ -26,10 +26,11 @@
2626
'source.directory' => 'src/main/java', # poxy Eclipse folders
2727
'project.build.sourceEncoding' => 'utf-8',
2828
'polyglot.dump.pom' => 'pom.xml',
29+
'jruby.version' => '9.3.0.0',
2930
'jruby.api' => 'http://jruby.org/apidocs/',
3031
)
3132

32-
jar 'org.jruby:jruby:9.2.19.0'
33+
jar 'org.jruby:jruby-base:${jruby.version}'
3334

3435
plugin_management do
3536
plugin :resources, '3.1.0'
@@ -45,7 +46,7 @@
4546
links: ['${jruby.api}']
4647
)
4748
plugin(
48-
:jar, '3.1.1',
49+
:jar, '3.2.0',
4950
archive: {
5051
manifestFile: 'MANIFEST.MF' # camel case reqd
5152
}

extensions/basic/jruby-ext/pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ DO NOT MODIFY - GENERATED CODE
1111
<modelVersion>4.0.0</modelVersion>
1212
<groupId>com.purbon</groupId>
1313
<artifactId>jruby-ext</artifactId>
14-
<version>1.2.2</version>
14+
<version>1.3.0</version>
1515
<name>jruby-ext</name>
1616
<description>example JRuby extension</description>
1717
<developers>
@@ -44,8 +44,8 @@ DO NOT MODIFY - GENERATED CODE
4444
<dependencies>
4545
<dependency>
4646
<groupId>org.jruby</groupId>
47-
<artifactId>jruby</artifactId>
48-
<version>9.2.19.0</version>
47+
<artifactId>jruby-base</artifactId>
48+
<version>9.3.0.0</version>
4949
</dependency>
5050
</dependencies>
5151
<build>

0 commit comments

Comments
 (0)