Rails 7.1 support

[mullermp]

Hello. The README suggests that the gem 71.x should support Rails 7.1 but I don't see any of these versions published to https://rubygems.org/gems/activerecord-jdbc-adapter or for the adapters.

[mullermp]

I'm currently doing something like:

  gem 'activerecord-jdbc-adapter', '~> 71.0',
      platform: :jruby,
      # this is not published for some reason
      git: 'https://github.com/jruby/activerecord-jdbc-adapter',
      glob: 'activerecord-jdbc-adapter.gemspec'
  gem 'activerecord-jdbcsqlite3-adapter', '~> 71.0',
      platform: :jruby,
      # this is not published for some reason
      git: 'https://github.com/jruby/activerecord-jdbc-adapter',
      glob: 'activerecord-jdbcsqlite3-adapter/activerecord-jdbcsqlite3-adapter.gemspec'

to pull the latest from github which essentially is 71.x support. 72.x support is still missing though.

[headius]

If my assessment is correct, 7.1 support is pretty solid for SQLite, nearly solid for MySQL, and still needs work for PostgreSQL. We know we need to get these out, plus 7.2 support, but we have been bogged down with lots of other issues the past few months.

@kares @enebo What's the status here?

[enebo]

@headius you have the right summary. we just need some time to get to this or some more help (which we got quite a bit a couple of months ago).

[mullermp]

How can I help? Do you have existing tests that would verify the completeness of those adapters when they are fully upgraded? What is the acceptance criteria to be ready for release?

[RTrampov]

Hey guys, happy new year!

Rails 7.0 security supports ends on 01 Apr 2025 and people are starting to look into updating to Rails 7.1 or 7.2. Is there any progress on adding support for newer Rails versions?

[headius]

@RTrampov It's a high priority but we are very resource-limited. 😫

My assessment above has not changed. We will try to get something out soon at least for SQLite and MySQL. We need help with PG... if you or someone else here can assist, stop by our Matrix channel and we'll get you set up!

[JesseChavez]

Hi everyone,

The adapter has a decent support for Rails 7.1 and 7.2, I did more testing for Rails 7.2 and at the moment I haven't see any issue in my internal CI for several JRuby on Rails applications

There are still some things to be done, just from the top of my head

• Message pack support (pending)
• Tomcat/Jetty support (very likely broken, active record changed how to handle db connections, this adapter used to use some callbacks to pass the db connection to Tomcat)
• and other edge cases that I forget.

It would be good you guys try the adapter from master branch or my fork

sqlite

platforms :ruby do
  # Use sqlite3 as the database for Active Record
  gem "sqlite3", ">= 1.4"
end

platforms :jruby do
  # gem 'activerecord-jdbc-adapter', path: '../../vendor_gems/activerecord-jdbc-adapter'
  gem "activerecord-jdbc-alt-adapter", "~> 72.0.0.rc1"
  gem "jdbc-sqlite3"
end

postgres

platforms :ruby do
  # Use postgresql as the database for Active Record
  gem "pg", "~> 1.1"
end

platforms :jruby do
  # gem 'activerecord-jdbc-adapter', path: '../../vendor_gems/activerecord-jdbc-adapter'
  gem "activerecord-jdbc-alt-adapter", "~> 72.0.0.rc1"
  gem "jdbc-pgsql"
end

Any issue you find please file a ticket here I will look at it

Thanks

[pboling]

I will add this to the omniauth-identity CI today!

@JesseChavez It looks like your forks's stable-dev is nearly 500 commits ahead of master... What is the best way to target your fork?

[pboling]

@JesseChavez When I use the following:

  platforms :jruby do
    gem "activerecord-jdbc-adapter", github: "JesseChavez/activerecord-jdbc-adapter", branch: "stable-dev"
    gem "activerecord-jdbcsqlite3-adapter", github: "JesseChavez/activerecord-jdbc-adapter", branch: "stable-dev"
    gem "jdbc-sqlite3", github: "JesseChavez/activerecord-jdbc-adapter", branch: "stable-dev"
  end

I get this error:

An error occurred while installing activerecord-jdbc-adapter (72.0.0.rc1), and
Bundler cannot continue.

In ar_7_2.gemfile:
  activerecord-jdbcsqlite3-adapter was resolved to 72.0.0.rc1, which depends on
    activerecord-jdbc-adapter

What's the right way to do this?

[JesseChavez]

the easiest would be:

platforms :jruby do
  gem "activerecord-jdbc-alt-adapter", "~> 72.0.0.rc1"
  gem "jdbc-sqlite3"
end

the more complex way would be:

platforms :jruby do
    gem "activerecord-jdbc-adapter", github: "JesseChavez/activerecord-jdbc-adapter", branch: "stable-dev"

    gem "jdbc-sqlite3"
end

[pboling]

I need both! I am setting up the CI on omniauth-identity to test against:

• all minor version stable releases of all ruby engines,
• all key installable minor versions of declared runtime dependencies
• all key installable minor versions of optional runtime dependencies
• all ruby engines @ HEAD
• all declared runtime dependencies @ HEAD
• all optional runtime dependencies @ HEAD <======= This is why I need the git version

[pboling]

Also, I see that both your fork and jruby's master are targeting Rails ~> 7.2.2.

Is there no way to target builds against Rails 8?

[enebo]

@JesseChavez @pboling I just create 72-stable so that any 8 work will not interfere and that can happen on master.