Merge pull request #29 from jrjoacir/fix/build-containers

Correct build containers add 'bundle exec' ruby commands in docker-co…

Author: jrjoacir

.travis.yml

@@ -6,6 +6,6 @@ install:
   - docker-compose up test
 
 script:
-  - docker-compose run --rm test rspec
-  - docker-compose run --rm test rubocop
+  - docker-compose run --rm test bundle exec rspec
+  - docker-compose run --rm test bundle exec rubocop
   - docker-compose rm -f

CHANGELOG.md

@@ -3,6 +3,13 @@ Here you can know about project evolution.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## Unreleased
+### Changed
+- Added **bundle exec** ruby command in docker-compose.yml file in command keys
+- Corrected simplecov file configuration to execute require in simplecov gem
+- Corrected spec_helper file to execute require in simplecov configuration file
+- Updated README to add **bundle exec** in ruby commands
+
 ## [2.0.0] - 2019-11-17
 ### Added
 - Container migrate just to run migrations on test and development databases

README.md

@@ -127,13 +127,13 @@ Execute all tests with following command:
 
 
 ```bash
-docker-compose run --rm test rspec
+docker-compose run --rm test bundle exec rspec
 ```
 
 For execute just one file test, you can inform a file in end of command.
 
 ```bash
-docker-compose run --rm test rspec spec/services/healthcheck/get_service_spec.rb
+docker-compose run --rm test bundle exec rspec spec/services/healthcheck/get_service_spec.rb
 ```
 
 This project uses [Rspec](https://relishapp.com/rspec/) Ruby gem as a test tool.
@@ -149,13 +149,13 @@ docker-compose up test
 This project uses [Rubocop](https://www.rubocop.org) Ruby gem as a Code Analizer tool, so analize all code with following command.
 
 ```bash
-docker-compose run --rm test rubocop
+docker-compose run --rm test bundle exec rubocop
 ```
 
 For analize just one file, you can inform a file in end of command.
 
 ```bash
-docker-compose run --rm test rubocop app/services/healthcheck/get_service.rb
+docker-compose run --rm test bundle exec rubocop app/services/healthcheck/get_service.rb
 ```
 
 ### Code coverage

config/simplecov.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'simplecov'
+
 SimpleCov.start do
   add_filter '/spec/'
   add_filter '/config/'

docker-compose.yml

@@ -23,7 +23,7 @@ services:
       - ./.env.development
     volumes:
       - .:/usr/src/app
-    command: sh -c "rake db:migrate && puma -p 3000"
+    command: sh -c "bundle exec rake db:migrate && bundle exec puma -p 3000"
 
   test:
     build:
@@ -35,7 +35,7 @@ services:
       - ./.env.test
     volumes:
       - .:/usr/src/app
-    command: sh -c "rake db:migrate"
+    command: sh -c "bundle exec rake db:migrate"
 
   apiblueprint:
     image: quay.io/bukalapak/snowboard

docker/app/Dockerfile

@@ -2,7 +2,7 @@ FROM ruby:2.6.4-alpine
 WORKDIR /usr/src/app
 RUN apk --no-cache add build-base postgresql-dev
 COPY Gemfile Gemfile.lock ./
-RUN gem update --system
-RUN gem install bundler
-RUN bundle install
+RUN gem update --system \
+    && gem install bundler \
+    && bundle install
 COPY . .

spec/spec_helper.rb

@@ -14,9 +14,8 @@
 #
 
 ENV['RACK_ENV'] ||= 'test'
-
-require_relative "../application"
 require_relative '../config/simplecov'
+require_relative "../application"
 require_dir 'spec/factories'
 
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration