Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to add blame command? #59

Open
dkns opened this issue Jan 9, 2016 · 8 comments
Open

Any plans to add blame command? #59

dkns opened this issue Jan 9, 2016 · 8 comments
Labels
backlog This issue will be done later new feature

Comments

@dkns
Copy link

dkns commented Jan 9, 2016

Hi, awesome plugin! Thanks a lot for creating it. One thing I would love to see is blame command implemented. Any plans to add it in the future?

@fpnick
Copy link

fpnick commented Jan 9, 2016

+1

@jreybert
Copy link
Owner

Hi

fugitive and vim-gita already implement nice git blame feature (gita's one is really nice, have a look).

Actually, both existing solutions seems OK to me. I don't intend to copy something working well. But if you have any idea of a git blame integrating well in the magit workflow, let me know!

I'll check how emacs magit handles got blame, to see if it is inspiring.

@dkns
Copy link
Author

dkns commented Jan 13, 2016

Yeah, vim-gita is awesome but I'd rather not load separate vim plugin just to have nice looking blame interface. Let me know if you need any help with developing this one.

@jreybert
Copy link
Owner

As I don't see what vimagit could bring more for git blame vim integration, I don't plan to implement it.

This is the Unix philosophy: Write programs that do one thing and do it well.

If you can see a way where the vimagit workflow could integrate a git blame output in an interesting manner, I would be happy to see it! Feel free to reopen this ticket in this case.

@kristijanhusak
Copy link

@jreybert why vimagit has to bring more to git blame then fugitive or gita? Most of people want to use only one git plugin, and as @dkns noted, pulling in another plugin just to use single feature is redundant.
It's same for me, only thing i use from fugitive is blame, since i don't like the other parts, but here i like everything, but only missing this blame feature. I agree with Unix philosophy, but i don't think it applies here. It would apply if we would have a plugin that is used only for blame, like a vim-fugitive-blame, but that's not the case, fugitive has a lot of it's own features.

@jreybert
Copy link
Owner

jreybert commented Apr 5, 2018

Hi @kristijanhusak .

You are quite right, use only one plugin would be better. But:

So, I am sorry, but integrate a blame feature in vimagit is very low priority...

@kristijanhusak
Copy link

@jreybert I understand that it's low priority, and that's completely fine, but rejecting it should not be a case. @dkns offered to contribute, so if someone else can do it, why not.

@jreybert
Copy link
Owner

jreybert commented Apr 5, 2018

You make a point. I remove the rejected flag and reopen the issue.

@dkns, if you are still interested to develop this new feature, feel free!

@jreybert jreybert reopened this Apr 5, 2018
@jreybert jreybert added the backlog This issue will be done later label Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog This issue will be done later new feature
Projects
None yet
Development

No branches or pull requests

4 participants