Skip to content

Commit 73291fe

Browse files
committed
oops we didn't declare a six dependency!!
1 parent 6c56fa4 commit 73291fe

File tree

4 files changed

+20
-2
lines changed

4 files changed

+20
-2
lines changed

setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
description="A python client library for taskwarrior's taskd",
1111
license="GPL v3+",
1212
zip_safe=False,
13+
install_requires=["six"],
1314
url="https://github.com/jrabbit/taskd-client-py",
1415
keywords=['taskwarrior', 'taskd', 'client'],
1516
classifiers=["License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)",

taskc/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = "0.0.3b2"
1+
__version__ = "0.0.3"

taskc/simple.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,10 @@ def _connect(self):
7171
context.load_verify_locations(cafile=self.cacert_file)
7272
elif self.cacert:
7373
print(self.cacert) # TODO: Replace prints with logging
74+
if six.PY2:
75+
raise NotImplementedError
76+
77+
logger.info("Got CA cert as data/string type: %s", type(self.cacert))
7478
context.load_verify_locations(cadata=self.cacert)
7579

7680
# enable for non-selfsigned certs

taskc/test_simple.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
except ImportError:
1515
import mock
1616

17-
logging.basicConfig(level=logging.DEBUG)
17+
logging.basicConfig(level=logging.INFO)
1818

1919
class TestRCParse(unittest.TestCase):
2020

@@ -129,6 +129,19 @@ def test_put(self):
129129
resp = self.tc.put(tasks)
130130
self.assertEqual(resp.status_code, 200)
131131
# might not be correct depends on state of taskd
132+
133+
def test_cadata(self):
134+
"This doesn't work in python2.7??"
135+
self.tc.cacert_file = False
136+
with open("taskc/fixture/pki/ca.cert.pem") as ca:
137+
self.tc.cacert = ca.read()
138+
self.tc._connect()
139+
# print self.tc.conn.getpeername()
140+
self.assertEqual(self.tc.conn.getpeername(), ('127.0.0.1', self.tc.port))
141+
# make sure we're on TLS v2 per spec
142+
self.assertEqual(self.tc.conn.context.protocol, 2)
143+
self.tc.conn.close()
144+
132145
def tearDown(self):
133146
print(self.docker.logs(self.container['Id'], stdout=True, stderr=True))
134147
self.docker.remove_container(self.container['Id'], force=True)

0 commit comments

Comments
 (0)