Core: Deprecate jQuery.isArray

kumarmj · mgol · commit 1b9575b9d143 · 2016-11-30T12:22:24.000+01:00
Fixes gh-2961 Closes gh-3278
diff --git a/src/attributes/val.js b/src/attributes/val.js
@@ -62,7 +62,7 @@ jQuery.fn.extend( {
 			} else if ( typeof val === "number" ) {
 				val += "";
 
-			} else if ( jQuery.isArray( val ) ) {
+			} else if ( Array.isArray( val ) ) {
 				val = jQuery.map( val, function( value ) {
 					return value == null ? "" : value + "";
 				} );
@@ -173,7 +173,7 @@ jQuery.extend( {
 jQuery.each( [ "radio", "checkbox" ], function() {
 	jQuery.valHooks[ this ] = {
 		set: function( elem, value ) {
-			if ( jQuery.isArray( value ) ) {
+			if ( Array.isArray( value ) ) {
 				return ( elem.checked = jQuery.inArray( jQuery( elem ).val(), value ) > -1 );
 			}
 		}
diff --git a/src/core.js b/src/core.js
@@ -172,11 +172,11 @@ jQuery.extend = jQuery.fn.extend = function() {
 
 				// Recurse if we're merging plain objects or arrays
 				if ( deep && copy && ( jQuery.isPlainObject( copy ) ||
-					( copyIsArray = jQuery.isArray( copy ) ) ) ) {
+					( copyIsArray = Array.isArray( copy ) ) ) ) {
 
 					if ( copyIsArray ) {
 						copyIsArray = false;
-						clone = src && jQuery.isArray( src ) ? src : [];
+						clone = src && Array.isArray( src ) ? src : [];
 
 					} else {
 						clone = src && jQuery.isPlainObject( src ) ? src : {};
@@ -215,8 +215,6 @@ jQuery.extend( {
 		return jQuery.type( obj ) === "function";
 	},
 
-	isArray: Array.isArray,
-
 	isWindow: function( obj ) {
 		return obj != null && obj === obj.window;
 	},
diff --git a/src/css.js b/src/css.js
@@ -404,7 +404,7 @@ jQuery.fn.extend( {
 				map = {},
 				i = 0;
 
-			if ( jQuery.isArray( name ) ) {
+			if ( Array.isArray( name ) ) {
 				styles = getStyles( elem );
 				len = name.length;
 
diff --git a/src/data/Data.js b/src/data/Data.js
@@ -115,7 +115,7 @@ Data.prototype = {
 		if ( key !== undefined ) {
 
 			// Support array or space separated string of keys
-			if ( jQuery.isArray( key ) ) {
+			if ( Array.isArray( key ) ) {
 
 				// If key is an array of keys...
 				// We always set camelCase keys, so remove that.
diff --git a/src/deprecated.js b/src/deprecated.js
@@ -25,6 +25,7 @@ jQuery.fn.extend( {
 	}
 } );
 
+jQuery.isArray = Array.isArray;
 jQuery.parseJSON = JSON.parse;
 
 } );
diff --git a/src/effects.js b/src/effects.js
@@ -256,7 +256,7 @@ function propFilter( props, specialEasing ) {
 		name = jQuery.camelCase( index );
 		easing = specialEasing[ name ];
 		value = props[ index ];
-		if ( jQuery.isArray( value ) ) {
+		if ( Array.isArray( value ) ) {
 			easing = value[ 1 ];
 			value = props[ index ] = value[ 0 ];
 		}
diff --git a/src/queue.js b/src/queue.js
@@ -17,7 +17,7 @@ jQuery.extend( {
 
 			// Speed up dequeue by getting out quickly if this is just a lookup
 			if ( data ) {
-				if ( !queue || jQuery.isArray( data ) ) {
+				if ( !queue || Array.isArray( data ) ) {
 					queue = dataPriv.access( elem, type, jQuery.makeArray( data ) );
 				} else {
 					queue.push( data );
diff --git a/src/serialize.js b/src/serialize.js
@@ -17,7 +17,7 @@ var
 function buildParams( prefix, obj, traditional, add ) {
 	var name;
 
-	if ( jQuery.isArray( obj ) ) {
+	if ( Array.isArray( obj ) ) {
 
 		// Serialize array item.
 		jQuery.each( obj, function( i, v ) {
@@ -69,7 +69,7 @@ jQuery.param = function( a, traditional ) {
 		};
 
 	// If an array was passed in, assume that it is an array of form elements.
-	if ( jQuery.isArray( a ) || ( a.jquery && !jQuery.isPlainObject( a ) ) ) {
+	if ( Array.isArray( a ) || ( a.jquery && !jQuery.isPlainObject( a ) ) ) {
 
 		// Serialize the form elements
 		jQuery.each( a, function() {
@@ -115,7 +115,7 @@ jQuery.fn.extend( {
 				return null;
 			}
 
-			if ( jQuery.isArray( val ) ) {
+			if ( Array.isArray( val ) ) {
 				return jQuery.map( val, function( val ) {
 					return { name: elem.name, value: val.replace( rCRLF, "\r\n" ) };
 				} );
diff --git a/test/data/testinit.js b/test/data/testinit.js
@@ -169,7 +169,7 @@ this.ajaxTest = function( title, expect, options ) {
 		}
 		options = options || [];
 		requestOptions = options.requests || options.request || options;
-		if ( !jQuery.isArray( requestOptions ) ) {
+		if ( !Array.isArray( requestOptions ) ) {
 			requestOptions = [ requestOptions ];
 		}
 
diff --git a/test/data/testrunner.js b/test/data/testrunner.js
@@ -35,7 +35,7 @@ QUnit.assert.expectJqData = function( env, elems, key ) {
 		if ( elems.jquery && elems.toArray ) {
 			elems = elems.toArray();
 		}
-		if ( !supportjQuery.isArray( elems ) ) {
+		if ( !Array.isArray( elems ) ) {
 			elems = [ elems ];
 		}
 
diff --git a/test/unit/core.js b/test/unit/core.js
@@ -1161,7 +1161,7 @@ QUnit.test( "jQuery.extend(Object, Object)", function( assert ) {
 	assert.ok( jQuery.extend( true, {}, nestedarray )[ "arr" ] !== arr, "Deep extend of object must clone child array" );
 
 	// #5991
-	assert.ok( jQuery.isArray( jQuery.extend( true, { "arr": {} }, nestedarray )[ "arr" ] ), "Cloned array have to be an Array" );
+	assert.ok( Array.isArray( jQuery.extend( true, { "arr": {} }, nestedarray )[ "arr" ] ), "Cloned array have to be an Array" );
 	assert.ok( jQuery.isPlainObject( jQuery.extend( true, { "arr": arr }, { "arr": {} } )[ "arr" ] ), "Cloned object have to be an plain object" );
 
 	empty = {};
@@ -1282,7 +1282,7 @@ QUnit.test( "jQuery.extend(true,{},{a:[], o:{}}); deep copy with array, followed
 	result = jQuery.extend( true, {}, initial );
 
 	assert.deepEqual( result, initial, "The [result] and [initial] have equal shape and values" );
-	assert.ok( !jQuery.isArray( result.object ), "result.object wasn't paved with an empty array" );
+	assert.ok( !Array.isArray( result.object ), "result.object wasn't paved with an empty array" );
 } );
 
 QUnit.test( "jQuery.each(Object,Function)", function( assert ) {
diff --git a/test/unit/deprecated.js b/test/unit/deprecated.js
@@ -110,3 +110,9 @@ QUnit.test( "jQuery.parseJSON", function( assert ) {
 
 	assert.strictEqual( jQuery.parseJSON( [ 0 ] ), 0, "Input cast to string" );
 } );
+
+QUnit.test( "jQuery.isArray", function( assert ) {
+	assert.expect( 1 );
+
+	assert.strictEqual( jQuery.isArray, Array.isArray, "Array.isArray equals jQuery.isArray" );
+} );
diff --git a/test/unit/queue.js b/test/unit/queue.js
@@ -128,7 +128,7 @@ QUnit.test( "jQuery.queue should return array while manipulating the queue", fun
 
 	var div = document.createElement( "div" );
 
-	assert.ok( jQuery.isArray( jQuery.queue( div, "fx", jQuery.noop ) ), "jQuery.queue should return an array while manipulating the queue" );
+	assert.ok( Array.isArray( jQuery.queue( div, "fx", jQuery.noop ) ), "jQuery.queue should return an array while manipulating the queue" );
 } );
 
 QUnit.test( "delay()", function( assert ) {

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@ jQuery.fn.extend( {`
`25`	`25`	`}`
`26`	`26`	`} );`
`27`	`27`
	`28`	`+jQuery.isArray = Array.isArray;`
`28`	`29`	`jQuery.parseJSON = JSON.parse;`
`29`	`30`
`30`	`31`	`} );`
Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ function propFilter( props, specialEasing ) {`
`256`	`256`	`name = jQuery.camelCase( index );`
`257`	`257`	`easing = specialEasing[ name ];`
`258`	`258`	`value = props[ index ];`
`259`		`- if ( jQuery.isArray( value ) ) {`
	`259`	`+ if ( Array.isArray( value ) ) {`
`260`	`260`	`easing = value[ 1 ];`
`261`	`261`	`value = props[ index ] = value[ 0 ];`
`262`	`262`	`}`
Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ this.ajaxTest = function( title, expect, options ) {`
`169`	`169`	`}`
`170`	`170`	`options = options \|\| [];`
`171`	`171`	`requestOptions = options.requests \|\| options.request \|\| options;`
`172`		`- if ( !jQuery.isArray( requestOptions ) ) {`
	`172`	`+ if ( !Array.isArray( requestOptions ) ) {`
`173`	`173`	`requestOptions = [ requestOptions ];`
`174`	`174`	`}`
`175`	`175`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ QUnit.assert.expectJqData = function( env, elems, key ) {`
`35`	`35`	`if ( elems.jquery && elems.toArray ) {`
`36`	`36`	`elems = elems.toArray();`
`37`	`37`	`}`
`38`		`- if ( !supportjQuery.isArray( elems ) ) {`
	`38`	`+ if ( !Array.isArray( elems ) ) {`
`39`	`39`	`elems = [ elems ];`
`40`	`40`	`}`
`41`	`41`