Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events are incorrectly placed when their duration is less than step #1529

Closed
tobiasandersen opened this issue Nov 18, 2019 · 5 comments
Closed
Labels

Comments

@tobiasandersen
Copy link
Collaborator

Do you want to request a feature or report a bug?

Bug

What's the current behavior?

Events are incorrectly placed when their duration is less than the step property. In the image below you can see that the event starts at 16.00, but it's placed at the 15-16 slot (rather than on the 16-17 slot). You can see the behavior in this CodeSandbox as well.

image

This was bug introduced by #1204. I can see that @TrySound tried to fix it first by reverting the behavior added by the PR above with 17b6cfd but then added it back (with some adjustments) with 02c2892.

@Npervic
Copy link

Npervic commented Nov 20, 2019

I am experiencing the same problem. I wrote about it in this PR #1462 .

@stale
Copy link

stale bot commented Jan 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 19, 2020
@marwej
Copy link

marwej commented Jan 31, 2020

Same issue here. Also a case where duration is longer than step but start time is not "on step". (Edit: maybe this is just because the scale ends at 18:00 here.)

image

@stale stale bot removed the wontfix label Jan 31, 2020
@marwej
Copy link

marwej commented Jan 31, 2020

I changed step to 15, but then max seems to have extra 15 minutes which makes it look like the event ends at 18:00.

image

@tobiasandersen
Copy link
Collaborator Author

For me this was fixed with #1462.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants