-
Notifications
You must be signed in to change notification settings - Fork 60
Drop support for EOL Python 2.7 and 3.5 #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #117 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 109 100 -9
Branches 21 20 -1
=========================================
- Hits 109 100 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@jquast can we move forward with it? |
Hi, checking in one year later and resolved the conflict :) Looks like the Windows failures are caused by a GitHub bug: actions/setup-python#1034 Hopefully they'll fix it soon. |
@hugovk feel free to use my new action approach for this: aio-libs/frozenlist#622 + aio-libs/frozenlist#633. I'm planning to keep it alive because I've been wanting a better cache control anyway. |
Thanks, we're not in a rush with this PR, because we're still pending #120 and a release before looking at this one, so I think we can wait a bit longer. |
@hugovk fair! I just saw your back reference and realized I forgot to post about it over on the GH tracker. Did that just now. |
Just checking in that yes, we can finally drop 2.7 for an upcoming release this week or so, I have deferred/put #120 back into draft for now |
Merge conflict resolved. |
|
||
Execute unit tests using tox_:: | ||
|
||
tox -e py27,py35,py36,py37,py38,py39,py310,py311,py312,py313,py314 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
py313 and py314 were accidentally removed.
@@ -1,5 +1,5 @@ | |||
[tox] | |||
envlist = update, compile, autopep8, docformatter, isort, pylint, flake8, pydocstyle, docs, verify_tables, py{27, 35, 36, 37, 38, 39, 310, 311, 312, 313, 314}, pypy{27, 36, 37, 38, 39, 310} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GalaxySnail, I put them back in with PR #150
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, and well spotted 👍
- (re-) Add python 3.13 and 3.14 to testing, removed in #117 - fix a couple of tox steps that were broken when their dependencies were removed from requirements in #144 - update requirements.txt from requirements.in files, this should close most https://github.com/jquast/wcwidth/security/dependabot stuff - Also, a few small lint/docstring discovered by these tools (flake8 etc) - Change readthedocs.org links to readthedocs.io
Fixes #102.