Skip to content

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jan 29, 2024

Fixes #102.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c993aab) to head (a753ba4).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #117   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          109       100    -9     
  Branches        21        20    -1     
=========================================
- Hits           109       100    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@penguinolog
Copy link

@jquast can we move forward with it?

@jquast
Copy link
Owner

jquast commented Feb 15, 2024

Yes, we can move forward with this this week after the next release that includes #120 if there is such sincere interest from so many developers.

Do not mind about bringing the branch up to date, I will do that. Thank you for your effort @hugovk.

@hugovk
Copy link
Contributor Author

hugovk commented Feb 17, 2025

Hi, checking in one year later and resolved the conflict :)

Looks like the Windows failures are caused by a GitHub bug: actions/setup-python#1034 Hopefully they'll fix it soon.

@webknjaz
Copy link

@hugovk feel free to use my new action approach for this: aio-libs/frozenlist#622 + aio-libs/frozenlist#633. I'm planning to keep it alive because I've been wanting a better cache control anyway.

https://github.com/marketplace/actions/cache-python-deps

@hugovk
Copy link
Contributor Author

hugovk commented Feb 17, 2025

Thanks, we're not in a rush with this PR, because we're still pending #120 and a release before looking at this one, so I think we can wait a bit longer.

@webknjaz
Copy link

@hugovk fair! I just saw your back reference and realized I forgot to post about it over on the GH tracker. Did that just now.

@jquast
Copy link
Owner

jquast commented Sep 18, 2025

Just checking in that yes, we can finally drop 2.7 for an upcoming release this week or so, I have deferred/put #120 back into draft for now

@hugovk
Copy link
Contributor Author

hugovk commented Sep 18, 2025

Merge conflict resolved.

@jquast jquast merged commit 56b4327 into jquast:master Sep 18, 2025
44 checks passed

Execute unit tests using tox_::

tox -e py27,py35,py36,py37,py38,py39,py310,py311,py312,py313,py314
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py313 and py314 were accidentally removed.

@@ -1,5 +1,5 @@
[tox]
envlist = update, compile, autopep8, docformatter, isort, pylint, flake8, pydocstyle, docs, verify_tables, py{27, 35, 36, 37, 38, 39, 310, 311, 312, 313, 314}, pypy{27, 36, 37, 38, 39, 310}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same as above

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GalaxySnail, I put them back in with PR #150

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, and well spotted 👍

jquast added a commit that referenced this pull request Sep 20, 2025
- (re-) Add python 3.13 and 3.14 to testing, removed in #117
- fix a couple of tox steps that were broken when their dependencies were removed from requirements in #144
- update requirements.txt from requirements.in files, this should close most https://github.com/jquast/wcwidth/security/dependabot stuff
- Also, a few small lint/docstring discovered by these tools (flake8 etc)
-  Change readthedocs.org links to readthedocs.io
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropping python 2 and 3.5 and earlier?
5 participants