Testing updates #1268

marscher · 2025-04-05T15:49:36Z

deals with #827

… do not call startJVM in JPypeTestCase.setUp, but in a pytest fixture for the session scope.

test/jpypetest/conftest.py

+        import faulthandler
+        faulthandler.enable()
+        faulthandler.disable()
+    except: ## tODO: too broad exception handling


test/jpypetest/test_attr.py

test/jpypetest/test_mro.py

test/jpypetest/test_proxy.py

codecov · 2025-04-06T12:37:45Z

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.09%. Comparing base (fa54bca) to head (06670a4).
Report is 22 commits behind head on master.

Files with missing lines	Patch %	Lines
jpype/_core.py	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
+ Coverage   86.87%   87.09%   +0.22%     
==========================================
  Files         113      113              
  Lines       10336    10356      +20     
  Branches     4065     4064       -1     
==========================================
+ Hits         8979     9020      +41     
+ Misses        761      741      -20     
+ Partials      596      595       -1

Files with missing lines	Coverage Δ
jpype/__init__.py	`95.12% <100.00%> (ø)`
jpype/_jarray.py	`100.00% <100.00%> (ø)`
jpype/_jcollection.py	`100.00% <100.00%> (ø)`
jpype/_jvmfinder.py	`61.53% <100.00%> (ø)`
native/common/jp_context.cpp	`77.89% <100.00%> (+4.00%)`	⬆️
native/python/pyjp_module.cpp	`81.91% <100.00%> (ø)`
jpype/_core.py	`84.53% <85.71%> (-0.19%)`	⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Thrameos · 2025-04-15T01:13:43Z

I see you are working on one of those maintenance tasks. Which release are you targeting this for? We currently have three largish changes in the pipeline.

extend Java objects from Python
A Java to Python bridge
Modules

Not sure how long it will take to integrate it all but that does mean fairly substantial changes in the repo. You may want to not hold a maintenance PR too long in queue or it risks conflicts with the others.

Additionally, in order to test the reverse bridge I will need to push it into a branch on the main project as the release pipeline can only be triggered there. I will remove the branch once it is complete. The merge will happen as a regular PR.

marscher · 2025-04-16T05:16:24Z

We could also post pone this one in favor of the important changes. I can tidy up things later and do not want to interfere with the integration of the the main features.

Thrameos · 2025-04-16T11:44:25Z

I hate to lose work that you put in. I gave this a look over. There were two problems when I ran it locally that would need to be addressed.

The assertion on the harness built is okay. But getting hundreds of failed tests on the same failed assertion is not very useful. I changed that to pytest.exit(). Running from a raw checkout shows that we have three actions before a pytest will run.

harnesses need to be built
org.jpype.jar must be found
the dependency libs need to be pulled.

I believe all these things happen in our azure scripts, but a local user won't get those.

Next up, the one of the changes to subrun is definitely bad for me locally. It appears that subrun now tries to start the JVM. But many of the tests are built around the JVM not having been started. At least locally that caused every subrun test to fail on me. Not sure why it passes on azure. Reverting the changes fixed my local copy.

Also my pyproject.toml gave an error on the license file under Python 3.12.

You can see the changes in I required in.

https://github.com/Thrameos/jpype/tree/testing_updates

Beyond those changes what else is required to merge this in?

test/jpypetest/test_attr.py


    def testCallWithArray(self):
-        h2 = JClass('jpype.attr.Test1')()
+        h2 = JClass('org.jpype.test.attr.Test1')()


test/jpypetest/test_attr.py


    def testCallWithArrayMismatch(self):
-        h2 = JClass('jpype.attr.Test1')()
+        h2 = JClass('org.jpype.test.attr.Test1')()


test/jpypetest/test_mro.py

 class MroTestCase(common.JPypeTestCase):
    def testMro(self):
-        C = JClass('jpype.mro.C')
+        C = JClass('org.jpype.test.mro.C')


test/jpypetest/test_proxy.py

-        proxy = JProxy("jpype.proxy.TestInterface1", dict=d)
-        proxy = JProxy(["jpype.proxy.TestInterface1"], dict=d)
+        proxy = JProxy("org.jpype.test.proxy.TestInterface1", dict=d)
+        proxy = JProxy(["org.jpype.test.proxy.TestInterface1"], dict=d)


test/jpypetest/test_proxy.py

-        proxy = JProxy(["jpype.proxy.TestInterface1"], dict=d)
+        proxy = JProxy("org.jpype.test.proxy.TestInterface1", dict=d)
+        proxy = JProxy(["org.jpype.test.proxy.TestInterface1"], dict=d)



test/jpypetest/test_proxy.py

    def testMethods(self):
-        fixture = JClass("jpype.common.Fixture")()
+        fixture = JClass("org.jpype.test.common.Fixture")()



test/jpypetest/test_proxy.py

    def testMethods2(self):
-        fixture = JClass("jpype.common.Fixture")()
+        fixture = JClass("org.jpype.test.common.Fixture")()



marscher added 30 commits April 5, 2025 14:32

moved tests to subpkg jpype.test (1)

8cf243a

fix package names in java files

a733880

f array

713ed2b

f reflect

c90f7e3

f zzz

fe1ae88

f virt

0fa1fad

f functional

2aab970

f ref

d0b353a

f proxy

208a490

f directbuff

15cd159

f legacy

81f9d29

f attr

0d6f7aa

f exc

d15eeef

f forname

56734f0

f char

8199a29

f primitives

b689c92

f stuff

63f4342

f stuff

a7e0891

f stuff

6b4a38d

f imports

bbd6ee7

f javacoverage

b710142

f files

30ff565

[refactor out] Since we are relying on pytest for a long time now. We…

201c6e8

… do not call startJVM in JPypeTestCase.setUp, but in a pytest fixture for the session scope.

f javadoc

bbfa677

f classhints

3158ab8

f imports

ba5d336

f customizer

34b1e17

f collection

00dd676

f fff

e8c8f19

f boxed

6884dbd

marscher added 9 commits April 5, 2025 16:49

minor

4fc50c5

f overloads

ae3abab

f serial

1c43f94

store custom options for later access

a737464

f coverage

083c68b

f proxy multithreaded

a4e9ff3

cleanup

fe05d92

f startup (wip)

4ce1a22

merged master (squashed)

aa4ef97

github-advanced-security bot found potential problems Apr 5, 2025

View reviewed changes

marscher added 4 commits April 5, 2025 19:55

fix path

d468557

[pyproject.toml] fix license value (table is deprecated in setuptools)

4959f85

fix mypy issue

998e5dc

fix startup

06670a4

marscher added 5 commits April 6, 2025 15:14

cleanup

5f16998

finally moved all harness classes to "org.jpype.test" Java package.

fbd0dce

fix

aa6b6e0

use Ant to build testing jars (wip)

812f95d

use Ant to build testing jars (wip)

d5a7478

marscher added 4 commits April 16, 2025 07:24

[pyproject.toml] fix license

12d6ac2

replaced self.assertTrue with assert

3332693

fix path

2c7d41a

minor

37480cb

Merge branch 'master' into testing_updates

80072bc

github-advanced-security bot found potential problems Jul 8, 2025

View reviewed changes

Merge branch 'master' into testing_updates

95d3fc1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Testing updates #1268

Testing updates #1268

Uh oh!

marscher commented Apr 5, 2025 •

edited

Loading

Uh oh!

Check notice

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Apr 6, 2025 •

edited

Loading

Uh oh!

Thrameos commented Apr 15, 2025

Uh oh!

marscher commented Apr 16, 2025

Uh oh!

Thrameos commented Apr 16, 2025

Uh oh!

Check notice

Check notice

Check notice

Check warning

Check notice

Check notice

Check notice

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Testing updates #1268

Are you sure you want to change the base?

Testing updates #1268

Uh oh!

Conversation

marscher commented Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Check notice

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Apr 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Thrameos commented Apr 15, 2025

Uh oh!

marscher commented Apr 16, 2025

Uh oh!

Thrameos commented Apr 16, 2025

Uh oh!

Check notice

Check notice

Check notice

Check warning

Uh oh!

Check notice

Check notice

Check notice

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

marscher commented Apr 5, 2025 •

edited

Loading

codecov bot commented Apr 6, 2025 •

edited

Loading