Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 2.1+ compatibility (tests for 2.2.6) #66

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

willstott101
Copy link

Previously this Field responded with an attribute error when access directly from the class:

>>> Node.position
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/home/wstott/repos/django-positions/positions/fields.py", line 144, in __get__
    raise AttributeError("%s must be accessed via instance." % self.name)
AttributeError: position must be accessed via instance.

Django admin now relies on the following behaviour:

>>> from examples.nodes.models import *
>>> Node.position
<positions.fields.PositionField: position>
>>> Node.name
<django.db.models.query_utils.DeferredAttribute object at 0x7f6c6b2e9748>

@willstott101 willstott101 changed the title Django 2.1+ comaptiblity (tests for 2.2.2) Django 2.1+ comaptiblity (tests for 2.2.6) Oct 23, 2019
@willstott101 willstott101 changed the title Django 2.1+ comaptiblity (tests for 2.2.6) Django 2.1+ compatibility (tests for 2.2.6) Oct 24, 2019
@willstott101
Copy link
Author

ping: Anything I can do to help get this merged?

@berinhard
Copy link

Hi @jpwatts do you still maintain this project? I'd love to have @willstott101 features since it's now a more reliable fork IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants